From nobody Fri Jun 14 16:42:57 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W14pB1hxqz5P8NF; Fri, 14 Jun 2024 16:42:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W14pB0nBkz4vD7; Fri, 14 Jun 2024 16:42:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718383378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ne2u0aYBH+UyxGxSUpJVKi+fVro1XgWLmpSbwsrVGI0=; b=TYaxUB9fsnZsTLN86mgAcRWE/OTydinJsN0Prv2HUwKcbKrfRDyXIb6DQgeP+nKf53zvQu 5UVkzj6vm7vPzcaXbwCNZulvEQIRuW6VxPbvaYjL6ZTl5FCX4dAcrGjM5S0wJ2mhsFLQ4w VO/Cemsyw0oXiwOiSzrWzzl7KwAAGv7uOa4VSbdYxpcCVEeBlDUZj/ctgXJqcHag4Z0YUv 3Xug65ZpizKG9KsZ6u6DGR0jZzPl4NyGwkPdJ9nNDzyuBwzf0IsPccHueCwpqcoQDuQ3kv vFIjxF6cmY+vL06YB6iKzDGXgWHMz41J4YDfRgIpIBK1dBUSKsReS0kh7JVNkw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1718383378; a=rsa-sha256; cv=none; b=iJ21Bh9X/VecvjsS7niNvPC5L6UrKPs9PJ6eYTlOeIOoMTMej6VrMMvP8faXtCIPmUj0QE WfBNmtKzgVDc2EcElNZlukIs+jJ8M1O6TSU745ZuPFRoqM9l97tAevYn5DG8IWD99BM62f Smq+3rOn2B6/aIGxwm732efsEjFgD45SfWcvNSn3kQXFIxe6BmUJV2qJ+xuPQyfPwP5i+4 xcfWF1VLdviEcp8Moj66uzKgnWEZ7ShABLd01Bn/wvdWyTA/866i6fTstHRdCZjHovoJpS 5kYOc1wMLWiNgpaNSkR0cUi+wLrLw6ZT8lwNuh27hWjRqnXNkT1bQgvbBcSw0Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718383378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ne2u0aYBH+UyxGxSUpJVKi+fVro1XgWLmpSbwsrVGI0=; b=TWKup2YQQt4SeOPpma3dKh/qqL35cM2FJqsb38WiimpkzJO9u1iFxBQbGgONzfCUm6r9ZH mgaak0kVjJ6fW6LdRLPg7L3SNFXmCRT6wZoy6V82RL3+6OuSmg7I+lB8W6BrpRHyf4LWXD S2ccfRmvG/QmspcIwkw3IyXyY+RePLe7WJmj6ibGWt6Mrzn8TGJVjwbOIdvT6ThkI+HUJC 9av/eQEbclaptR3acYD4+Pw7gpZ+zTp796sg2sIIP4el2KdR4gvpfPxSUpCFSuXlcKXnDt G44AMJ44FbLPZO85tVznfEtY01tJxv0tQ6qkFztRuZwicK381NTU3o/2fruOxg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4W14pB0NYfzShF; Fri, 14 Jun 2024 16:42:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 45EGgvVV015807; Fri, 14 Jun 2024 16:42:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 45EGgvmP015804; Fri, 14 Jun 2024 16:42:57 GMT (envelope-from git) Date: Fri, 14 Jun 2024 16:42:57 GMT Message-Id: <202406141642.45EGgvmP015804@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: 97ab935d566c - main - rk_pinctrl: fix error check List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 97ab935d566c85458bc7cab99c402f026d704eff Auto-Submitted: auto-generated The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=97ab935d566c85458bc7cab99c402f026d704eff commit 97ab935d566c85458bc7cab99c402f026d704eff Author: John F. Carr AuthorDate: 2024-06-14 16:37:06 +0000 Commit: Mitchell Horne CommitDate: 2024-06-14 16:42:27 +0000 rk_pinctrl: fix error check The parse_bias method returns a signed int, with a value of -1 when the device tree reports nothing of the bias configuration. Convert the local 'bias' from unsigned to signed to properly check this condition. PR: 229721 Reviewed by: mhorne MFC after: 3 days --- sys/arm64/rockchip/rk_pinctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/arm64/rockchip/rk_pinctrl.c b/sys/arm64/rockchip/rk_pinctrl.c index 4892b0bf236c..6137f7f0d50a 100644 --- a/sys/arm64/rockchip/rk_pinctrl.c +++ b/sys/arm64/rockchip/rk_pinctrl.c @@ -1141,9 +1141,9 @@ rk_pinctrl_configure_pin(struct rk_pinctrl_softc *sc, uint32_t *pindata) { phandle_t pin_conf; struct syscon *syscon; - uint32_t bank, subbank, pin, function, bias; + uint32_t bank, subbank, pin, function; uint32_t bit, mask, reg, drive; - int i, rv; + int i, rv, bias; bank = pindata[0]; pin = pindata[1];