From nobody Sun Feb 11 13:30:59 2024 X-Original-To: transport@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TXpPv2skvz59kSK for ; Sun, 11 Feb 2024 13:30:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TXpPv0zWDz4MXS for ; Sun, 11 Feb 2024 13:30:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707658259; a=rsa-sha256; cv=none; b=C9zWnP1Au0x2ZtQcW466BDFoCU/Pby0w7weFFKosMWbwxpfyO/zp2piOG3KqJL0Ysj45xh stgedWxogS9C5qRrizklsxGlctr9xXEKPjv/P6CQchg4JseJGmwHO7yIx+XnASStI86WDR 81ssX0tMNINNjDwbExCTFgRscIDhTBmYIwWRS34RsVcT+izGLv6xBA80AFxUsw8Pr34SOy 03brn+tVRgMVvyFrQmydi+lG99QWo7li/w4PyJV5muE03RB3LfQ6iINakkqRXvYXNUobxH yYyu3T2p8hUtW//B3mN0YvaZcXkRcJXxe3HXBLITWqj6Gdtc5GMO2dPpImgLAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707658259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t/EbvdbRHWInhl1mU680DATpCh+G+NUIB681fxwMLYk=; b=KXI7zbVOMkf/6J0+GnzV9xbbfWNfD+wyx4zTwKgdXb2uDL9ccDaYfq1LA86deyq2XChTeh WXw3DPIq7V6Gi8ikzqePuhtw5phhusnJeIIxLXP0agmDwn90QjYLB1BT3YRn+0Jxk8vD8Z JDgsw8uMB6K5OO/SEsCxM9hfGMSpW/TgvgT8voVOVlQznE+qukhhIo+ZLPQvlPz4g6Ubhx neJ5voVwKDdE2PRYLkEvqNS3h6861S8RXP1FHBImfO5UZUuusMPgdmIW/nAN7kWR4HLWWn 9FTbUqwiWuO8R8APHPx3VIsVjE9wq+0grLLD4nCrspnMwcvIAmtjtmSJyoLFQQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TXpPv03jlz11Vn for ; Sun, 11 Feb 2024 13:30:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41BDUwq5026230 for ; Sun, 11 Feb 2024 13:30:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41BDUwVW026228 for transport@FreeBSD.org; Sun, 11 Feb 2024 13:30:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: transport@FreeBSD.org Subject: [Bug 276761] panic: sbsndptr_noadv: sb_mb is NULL Date: Sun, 11 Feb 2024 13:30:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rscheff@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: transport@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-transport List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-transport@freebsd.org X-BeenThere: freebsd-transport@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276761 Richard Scheffenegger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Closed |In Progress Resolution|FIXED |--- --- Comment #16 from Richard Scheffenegger --- Yes, I suspect that TT_2MSL is allowed to be active. Would you be willing to test these checks instead of a catch-all if any tim= er is active: diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c index 90e1496a822c..8acb03d8e3d1 100644 --- a/sys/netinet/tcp_subr.c +++ b/sys/netinet/tcp_subr.c @@ -2383,7 +2383,11 @@ tcp_discardcb(struct tcpcb *tp) #endif INP_WLOCK_ASSERT(inp); - MPASS(!callout_active(&tp->t_callout)); + /* only allow TT_2MSL for TIMEWAIT */ + MPASS(!tcp_timer_active(tp, TT_REXMT)); + MPASS(!tcp_timer_active(tp, TT_PERSIST)); + MPASS(!tcp_timer_active(tp, TT_KEEP)); + MPASS(!tcp_timer_active(tp, TT_DELACK)); MPASS(TAILQ_EMPTY(&tp->snd_holes)); /* free the reassembly queue, if any */ Syzcaller found this, but without a reproducer (or core). The above, if it's another timer than TT_2MSL, which would be expected for TIME-WAIT, would yi= eld a dedicated panic line... --=20 You are receiving this mail because: You are the assignee for the bug.=