From nobody Mon Sep 29 15:22:37 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cb4gd56qzz68Nkd; Mon, 29 Sep 2025 15:22:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cb4gd204Vz46ZK; Mon, 29 Sep 2025 15:22:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759159357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TSP7mK6Tb78uL2dr19FQ8yDmp72VRKmM9cNrbhWmSRY=; b=SokejwTLqZMyGm9nu6xZXZCXAERiPN9s26tcSDjq3xmkZ8cKmHoE0M7gjT/Hv3B352xPug vmJMyPqnwkAn5Q/qiX40yCMl5oz1wL5WbN5NJ8H4V5bs19nRGM0NNxj6FdQKA+/pyT0fKR 0LoL2F2/Ng6OLDfRKzULHcXiw+qKNDo+rPSfCvPv+8cOoad2Z/Vj7nNvDnq2qasEOcu3hv 8yR3UA708nxvhYORkCB0vPAioXrH+fh8QomzwxCP/dzHjw7XZAcuUAxKuGY2AHe50neZou IiarHblRcqXUp8encJnJ8HZ7GvQnc/e8N3tyo2iHSMF+SUPrRTBuGfpGqyNpiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759159357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TSP7mK6Tb78uL2dr19FQ8yDmp72VRKmM9cNrbhWmSRY=; b=a2jwTPjrU3uaUgcC8r/twpmGNjJO7I5U7ANvVY9yAgQOeUGrnLTFBpWfPE9eaNU1x1V3t2 KVYQYtC6Y5lrvU4PfrLz/hWAbGRPncJ6QY7egPiH1NaZ0pup2Hv2rGc8IiY2swhV3aAQCt QTZ1Vi3vBbHJKWVqL90Sw9akuQ3vGXFM8HGt3Dg6EslRJMy4JmwAs6WE36jF+QBRnsbnny mid6nPfZA68W++1Vn1hUtSl/05Sl2aTblewcspXSmDNqsfq6/JTYWzA5pnyQGvlAL4VLrk Z1YzvmfcoXKszyYRgwV6T7dIQOR6VIaszZv1n0MTwNglURmQkSsjHrnebrIemA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759159357; a=rsa-sha256; cv=none; b=I8XVovbGYPSnUUAa0xY1caGihgrIrJEWiMBLQe5K8LpLSC0sZEqWBgy0puLSZQe7bl8I3X mFeiSnBRwJ2vAohxCv9YtqgEeW7A+QEHwXcqp1Qk05eRZzXPXDmk5Vb/C+hw6jlUXECg7Z dDPttBSBOFa+tq0h6vN5QY7gX0INSLdcjYFPbcg1UBw7Vhx4vzi3K+qC7dLdH6h5ABAkbw SUGfZup7z2X3Jh+TRrwcjRXzF1fo9eQQGQadfxLXmQhDqF2mISIMMtw9t/fv7r40RPA+ip QgMjS2d8kUIpN4i4gNQBUBgVZra/z8hhnGRU1q567ziAmgE6gTyuV0AhczJWvg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cb4gd1W8sz19gl; Mon, 29 Sep 2025 15:22:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58TFMbFR012088; Mon, 29 Sep 2025 15:22:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58TFMb2M012085; Mon, 29 Sep 2025 15:22:37 GMT (envelope-from git) Date: Mon, 29 Sep 2025 15:22:37 GMT Message-Id: <202509291522.58TFMb2M012085@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: e2fae07e093b - main - cxgbe TOE TLS: Support for TLS 1.3 for receive List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e2fae07e093bf4953ad7359b2aa9ca62b0d76adf Auto-Submitted: auto-generated The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=e2fae07e093bf4953ad7359b2aa9ca62b0d76adf commit e2fae07e093bf4953ad7359b2aa9ca62b0d76adf Author: John Baldwin AuthorDate: 2025-09-29 15:10:08 +0000 Commit: Navdeep Parhar CommitDate: 2025-09-29 15:19:13 +0000 cxgbe TOE TLS: Support for TLS 1.3 for receive MFC after: 3 days Sponsored by: Chelsio Communications --- sys/dev/cxgbe/tom/t4_tls.c | 51 +++++++++++++++++++++++++++++++++++++--------- 1 file changed, 41 insertions(+), 10 deletions(-) diff --git a/sys/dev/cxgbe/tom/t4_tls.c b/sys/dev/cxgbe/tom/t4_tls.c index 677fd143e248..bbcc1c88c3db 100644 --- a/sys/dev/cxgbe/tom/t4_tls.c +++ b/sys/dev/cxgbe/tom/t4_tls.c @@ -240,11 +240,6 @@ tls_alloc_ktls(struct toepcb *toep, struct ktls_session *tls, int direction) if (is_t6(sc)) { return (EPROTONOSUPPORT); } - - /* Only TX for TLS 1.3 for now. */ - if (direction == KTLS_RX) { - return (EPROTONOSUPPORT); - } } /* Sanity check values in *tls. */ @@ -305,8 +300,8 @@ tls_alloc_ktls(struct toepcb *toep, struct ktls_session *tls, int direction) if (error) return (error); + toep->tls.tls13 = tls->params.tls_vminor == TLS_MINOR_VER_THREE; if (direction == KTLS_TX) { - toep->tls.tls13 = tls->params.tls_vminor == TLS_MINOR_VER_THREE; toep->tls.scmd0.seqno_numivs = (V_SCMD_SEQ_NO_CTRL(3) | V_SCMD_PROTO_VERSION(t4_tls_proto_ver(tls)) | @@ -834,8 +829,8 @@ do_rx_tls_cmp(struct sge_iq *iq, const struct rss_header *rss, struct mbuf *m) struct sockbuf *sb; struct mbuf *tls_data; struct tls_get_record *tgr; - struct mbuf *control; - int pdu_length, trailer_len; + struct mbuf *control, *n; + int pdu_length, resid, trailer_len; #if defined(KTR) || defined(INVARIANTS) int len; #endif @@ -883,7 +878,9 @@ do_rx_tls_cmp(struct sge_iq *iq, const struct rss_header *rss, struct mbuf *m) /* * The payload of this CPL is the TLS header followed by - * additional fields. + * additional fields. For TLS 1.3 the type field holds the + * inner record type and the length field has been updated to + * strip the inner record type, padding, and MAC. */ KASSERT(m->m_len >= sizeof(*tls_hdr_pkt), ("%s: payload too small", __func__)); @@ -895,7 +892,14 @@ do_rx_tls_cmp(struct sge_iq *iq, const struct rss_header *rss, struct mbuf *m) ("%s: sequence mismatch", __func__)); } - /* Report decryption errors as EBADMSG. */ + /* + * Report decryption errors as EBADMSG. + * + * XXX: To support rekeying for TLS 1.3 this will eventually + * have to be updated to recrypt the data with the old key and + * then decrypt with the new key. Punt for now as KTLS + * doesn't yet support rekeying. + */ if ((tls_hdr_pkt->res_to_mac_error & M_TLSRX_HDR_PKT_ERROR) != 0) { CTR4(KTR_CXGBE, "%s: tid %u TLS error %#x ddp_vld %#x", __func__, toep->tid, tls_hdr_pkt->res_to_mac_error, @@ -913,6 +917,33 @@ do_rx_tls_cmp(struct sge_iq *iq, const struct rss_header *rss, struct mbuf *m) return (0); } + /* For TLS 1.3 trim the header and trailer. */ + if (toep->tls.tls13) { + KASSERT(tls_data != NULL, ("%s: TLS 1.3 record without data", + __func__)); + MPASS(tls_data->m_pkthdr.len == pdu_length); + m_adj(tls_data, sizeof(struct tls_record_layer)); + if (tls_data->m_pkthdr.len > be16toh(tls_hdr_pkt->length)) + tls_data->m_pkthdr.len = be16toh(tls_hdr_pkt->length); + resid = tls_data->m_pkthdr.len; + if (resid == 0) { + m_freem(tls_data); + tls_data = NULL; + } else { + for (n = tls_data;; n = n->m_next) { + if (n->m_len < resid) { + resid -= n->m_len; + continue; + } + + n->m_len = resid; + m_freem(n->m_next); + n->m_next = NULL; + break; + } + } + } + /* Handle data received after the socket is closed. */ sb = &so->so_rcv; SOCKBUF_LOCK(sb);