From owner-freebsd-testing@FreeBSD.ORG Fri Jul 19 21:13:47 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 80D68C71 for ; Fri, 19 Jul 2013 21:13:47 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-ve0-x235.google.com (mail-ve0-x235.google.com [IPv6:2607:f8b0:400c:c01::235]) by mx1.freebsd.org (Postfix) with ESMTP id 4583B194 for ; Fri, 19 Jul 2013 21:13:47 +0000 (UTC) Received: by mail-ve0-f181.google.com with SMTP id db10so3657444veb.40 for ; Fri, 19 Jul 2013 14:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=EuoMUoWCBZ7AuqTz1vBhgHXcwSraOmlRVREfRyqmoDQ=; b=dB2/dHBXUyEZJNcE6FRSRxSFoxXlcqulEG82cPCYyJ4Hio27fzUMDFIL820OeOBtwp AFUgLxorpy8b2bJZYf7bHxXYbmRRG/HaqK/lXLvH4UYmGKKAAdotKCn8y9pddeP4NOrV ScI+gbzs0YysZJAwBdgxZ+RBkPRtYG84AYSQSgPiFx+6ui07qEhJ8D3kaqBEI05+u3VL LWqSA12R7uprSoSUvQACl+ie1PpJXLd5deQvkon+ATitWfUxK08Z4QrCmDcXzUNeN2TI f7tky0HedUIedpH46wRhX07Orceoyy523z5gdi0TmQBv8xXEkMB9/QhI0cAVYYbVlSDe OCxA== MIME-Version: 1.0 X-Received: by 10.58.135.167 with SMTP id pt7mr6266114veb.75.1374268426862; Fri, 19 Jul 2013 14:13:46 -0700 (PDT) Received: by 10.220.146.145 with HTTP; Fri, 19 Jul 2013 14:13:46 -0700 (PDT) In-Reply-To: References: <20130719200017.GA79155@mastodon.meroh.net> Date: Fri, 19 Jul 2013 14:13:46 -0700 Message-ID: Subject: Re: Getting rid of the ATF tools From: Garrett Cooper To: Julio Merino Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-testing@freebsd.org, Rui Paulo X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2013 21:13:47 -0000 On Fri, Jul 19, 2013 at 2:06 PM, Julio Merino wrote: > On Fri, Jul 19, 2013 at 5:02 PM, Garrett Cooper wrote: >> (Pardon my message mangling as I'm forwarding this to freebsd-testing@ >> for context) > > Hm, I wanted to rewrite things a little bit before sending this > publicly but no big deal. Didn't know freebsd-testing existed! It's up on the wiki, but it's not as clearly marked as it could be :). It's a super duper low traffic list (I'm the only person that's posted to it since it's been recreated, apart from you now). >> gcooper> 2. Please move the OptionalObsoleteFiles.inc entries >> [re]moved to ObsoleteFiles.inc as they need to be removed from systems >> running CURRENT that have installed atf in the past (like my VM for >> instance). There aren't many people using ATF I suspect, but for those >> of us that are, it would be nice if the files were yanked completely. > > OK. Note, however, that the entries in OptionalObsoleteFiles.inc are > _outside_ of any MK* conditionals. Is there any case where they'd be > ignored? (curiosity) It's cleanliness and consistency more than anything else as the tools are being yanked (and I assume aren't coming back ever :D..). Adding in logic to check for commands seems unnecessary as make does a reasonable job with this already. On the plus side you're getting rid of bmake-isms which will make moving away from bmake a possibility in the future. I am against the fact that ATF/Kyua/etc can't easily be backported without the mess that's involved with converting the src tree over to bmake. It's already made my life more annoyingly painful than necessary. >> gcooper> 3. Please put in the needed bits for generating Kyuafiles in >> atf.test.mk. > > Yes, but that has to come separately. (And it should probably be in > bsd.test.mk, because Kyuafiles can represent both generic test > programs and ATF-specific test programs -- a major selling point for > using Kyua upfront in a system where non-ATF test programs already > exist.) Ok, but let's do that all in one fell swoop then. No reason to have an awkward stage of flux :). > Thanks for the comments! np -- thanks for your care/concern :).