From owner-cvs-src@FreeBSD.ORG Fri Jan 25 16:23:12 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40E2016A469; Fri, 25 Jan 2008 16:23:12 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id CD71A13C4F0; Fri, 25 Jan 2008 16:23:11 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.1/8.13.8) with ESMTP id m0PG4CYD037281; Fri, 25 Jan 2008 10:04:12 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.1/8.13.8/Submit) id m0PG4C3D037280; Fri, 25 Jan 2008 10:04:12 -0600 (CST) (envelope-from brooks) Date: Fri, 25 Jan 2008 10:04:12 -0600 From: Brooks Davis To: Ceri Davies Message-ID: <20080125160412.GA36311@lor.one-eyed-alien.net> References: <200801251506.m0PF6Qwf043571@repoman.freebsd.org> <20080125152102.GD6064@submonkey.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: <20080125152102.GD6064@submonkey.net> User-Agent: Mutt/1.5.16 (2007-06-09) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Fri, 25 Jan 2008 10:04:12 -0600 (CST) Cc: cvs-src@freebsd.org, Mike Makonnen , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc rc.subr X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2008 16:23:12 -0000 --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 25, 2008 at 03:21:02PM +0000, Ceri Davies wrote: > On Fri, Jan 25, 2008 at 03:06:26PM +0000, Mike Makonnen wrote: > > mtm 2008-01-25 15:06:26 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > etc rc.subr=20 > > Log: > > If the rc.conf(5) variable for a script is not enabled do not fail > > silently. Display a message that the command wasn't run and make > > possible suggestions for what to do. >=20 > Any chance that we could make this behaviour dependent on some other > variable (or not do it)? It's going to make booting look pretty nasty. The other option I'd considered was to create a quiet precmd that works like force and use quietstart/quitestop for boot. I've become convinced this is= the right interactive behavior. -- Brooks > Ceri >=20 > > | @@ -606,6 +606,9 @@ run_rc_command() > > | # > > | if [ -n "${rcvar}" -a "$rc_arg" !=3D "rcvar" ]; then > > | if ! checkyesno ${rcvar}; then > > | + echo -n "Cannot '${rc_arg}' $name. Set ${rcvar} to " > > | + echo -n "YES in /etc/rc.conf or use 'one${rc_arg}' " > > | + echo "instead of '${rc_arg}'." > > | return 0 > > | fi > > | fi >=20 > --=20 > That must be wonderful! I don't understand it at all. > -- Moliere --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFHmgh7XY6L6fI4GtQRAqY2AKCErLdmObtXAphEqtDsuCIaagol2gCg1GzE sei1smAdLTEBS1dBVbUenq0= =BVRr -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--