Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Jan 2008 10:04:12 -0600
From:      Brooks Davis <brooks@freebsd.org>
To:        Ceri Davies <ceri@submonkey.net>
Cc:        cvs-src@freebsd.org, Mike Makonnen <mtm@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/etc rc.subr
Message-ID:  <20080125160412.GA36311@lor.one-eyed-alien.net>
In-Reply-To: <20080125152102.GD6064@submonkey.net>
References:  <200801251506.m0PF6Qwf043571@repoman.freebsd.org> <20080125152102.GD6064@submonkey.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--J2SCkAp4GZ/dPZZf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 25, 2008 at 03:21:02PM +0000, Ceri Davies wrote:
> On Fri, Jan 25, 2008 at 03:06:26PM +0000, Mike Makonnen wrote:
> > mtm         2008-01-25 15:06:26 UTC
> >=20
> >   FreeBSD src repository
> >=20
> >   Modified files:
> >     etc                  rc.subr=20
> >   Log:
> >   If the rc.conf(5) variable for a script is not enabled do not fail
> >   silently. Display a message that the command wasn't run and make
> >   possible suggestions for what to do.
>=20
> Any chance that we could make this behaviour dependent on some other
> variable (or not do it)?  It's going to make booting look pretty nasty.

The other option I'd considered was to create a quiet precmd that works like
force and use quietstart/quitestop for boot.  I've become convinced this is=
 the
right interactive behavior.

-- Brooks

> Ceri
>=20
> > | @@ -606,6 +606,9 @@ run_rc_command()
> > |  					#
> > |  	if [ -n "${rcvar}" -a "$rc_arg" !=3D "rcvar" ]; then
> > |  		if ! checkyesno ${rcvar}; then
> > | +			echo -n "Cannot '${rc_arg}' $name. Set ${rcvar} to "
> > | +			echo -n "YES in /etc/rc.conf or use 'one${rc_arg}' "
> > | +			echo "instead of '${rc_arg}'."
> > |  			return 0
> > |  		fi
> > |  	fi
>=20
> --=20
> That must be wonderful!  I don't understand it at all.
>                                                   -- Moliere



--J2SCkAp4GZ/dPZZf
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFHmgh7XY6L6fI4GtQRAqY2AKCErLdmObtXAphEqtDsuCIaagol2gCg1GzE
sei1smAdLTEBS1dBVbUenq0=
=BVRr
-----END PGP SIGNATURE-----

--J2SCkAp4GZ/dPZZf--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080125160412.GA36311>