From owner-freebsd-bugs@FreeBSD.ORG Wed Oct 27 02:20:21 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 404EF16A4CE for ; Wed, 27 Oct 2004 02:20:21 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11E7843D45 for ; Wed, 27 Oct 2004 02:20:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i9R2KKXU046356 for ; Wed, 27 Oct 2004 02:20:20 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9R2KKci046355; Wed, 27 Oct 2004 02:20:20 GMT (envelope-from gnats) Resent-Date: Wed, 27 Oct 2004 02:20:20 GMT Resent-Message-Id: <200410270220.i9R2KKci046355@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Darrin Smith Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F15C716A4CE for ; Wed, 27 Oct 2004 02:17:03 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id E3C7C43D58 for ; Wed, 27 Oct 2004 02:17:03 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i9R2H3QN025106 for ; Wed, 27 Oct 2004 02:17:03 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.11/8.12.11/Submit) id i9R2H3BN025105; Wed, 27 Oct 2004 02:17:03 GMT (envelope-from nobody) Message-Id: <200410270217.i9R2H3BN025105@www.freebsd.org> Date: Wed, 27 Oct 2004 02:17:03 GMT From: Darrin Smith To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: misc/73183: nfs_diskless.c lacking include of #if options X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2004 02:20:21 -0000 >Number: 73183 >Category: misc >Synopsis: nfs_diskless.c lacking include of #if options >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Oct 27 02:20:20 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Darrin Smith >Release: 5.3-BETA6 >Organization: Salisbury East High School >Environment: FreeBSD big-brother.sehs.sec 5.3-BETA6 FreeBSD 5.3-BETA6 #3: Wed Oct 6 15:53:24 CST 2004 sdar@big-brother.sehs.sec:/src/obj/src/src5/sys/SEHS i386 >Description: sys/nfsclient/nfs_diskless.c contains and #if !defined(BOOTP_NFSROOT) near the bottom of the file which is ALWAYS included since "opt_bootp.h" is not included in the file. >How-To-Repeat: insert an #error inside #ifdef, define BOOTP_NFSROOT in kernel config, compile and error will trigger >Fix: Apply patch: Index: nfs_diskless.c =================================================================== RCS file: /home/ncvs/src/sys/nfsclient/nfs_diskless.c,v retrieving revision 1.8 diff -u -r1.8 nfs_diskless.c --- nfs_diskless.c 28 Jul 2004 21:54:57 -0000 1.8 +++ nfs_diskless.c 27 Oct 2004 01:33:25 -0000 @@ -35,6 +35,8 @@ #include __FBSDID("$FreeBSD: src/sys/nfsclient/nfs_diskless.c,v 1.8 2004/07/28 21:54:57 phk Exp $"); +#include "opt_bootp.h" + #include #include #include >Release-Note: >Audit-Trail: >Unformatted: