From owner-freebsd-net@freebsd.org Fri Feb 5 07:55:22 2016 Return-Path: <owner-freebsd-net@freebsd.org> Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD35E9D9422 for <freebsd-net@mailman.ysv.freebsd.org>; Fri, 5 Feb 2016 07:55:22 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.rbsd.freebsd.org (unknown [IPv6:2607:fc50:2000:101::1bb:73]) by mx1.freebsd.org (Postfix) with ESMTP id 998E51F1C for <freebsd-net@freebsd.org>; Fri, 5 Feb 2016 07:55:22 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.rbsd.freebsd.org (Postfix, from userid 1346) id 960D71074BF; Fri, 5 Feb 2016 07:55:22 +0000 (UTC) Date: Fri, 5 Feb 2016 07:55:22 +0000 To: freebsd-net@freebsd.org From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org> Reply-to: D4825+325+15e38f1ea6d5e28b@reviews.freebsd.org Subject: [Differential] [Commented On] D4825: tcp/lro: Add network driver configurable LRO entry depth Message-ID: <6c36f266ce528c279fcc03757474360a@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: <differential-comment> Thread-Topic: D4825: tcp/lro: Add network driver configurable LRO entry depth X-Herald-Rules: <64> X-Phabricator-To: <PHID-USER-owbigh336siepsaab2ye> X-Phabricator-To: <PHID-PROJ-62ihepuxzgyzg7rh5uic> X-Phabricator-To: <PHID-PROJ-u7z45dkhkb4gc5luse77> X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii> X-Phabricator-To: <PHID-USER-n3y55yy4j7xarsdk3otz> X-Phabricator-To: <PHID-USER-aojo5yplx3m2nkpgwndr> X-Phabricator-To: <PHID-USER-57eqaez2c2qhlyhs4xoi> X-Phabricator-To: <PHID-USER-4lzxzqflpaankb5hk2y4> X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3> X-Phabricator-Cc: <PHID-USER-mdwvnzzsrozqcmzhmbra> X-Phabricator-Cc: <PHID-USER-mqlw6f5jjiqhbs4co7yd> X-Phabricator-Cc: <PHID-USER-dyyyzfp34mimhzvg33tk> Precedence: bulk In-Reply-To: <differential-rev-PHID-DREV-ou2jiti5cx3pzqhm5pb2-req@FreeBSD.org> References: <differential-rev-PHID-DREV-ou2jiti5cx3pzqhm5pb2-req@FreeBSD.org> Thread-Index: NmVkZTllNGEwNGViMzMwZDAzYzdjMGY0Y2Y4IFa0VWo= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/> List-Post: <mailto:freebsd-net@freebsd.org> List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 05 Feb 2016 07:55:22 -0000 sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D4825#110653, @hselasky wrote: > FYI > > https://reviews.freebsd.org/D1761 might be related to this one. > > Should you check that "lc->lro_hiwat" is greater or equal to "lc->ifp->if_mtu" ? > > --HPS I have discarded this one, please take a look at this: https://reviews.freebsd.org/D5185 Thanks, sephe REVISION DETAIL https://reviews.freebsd.org/D4825 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, transport, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, glebius Cc: hselasky, np, freebsd-net-list