Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Nov 2009 12:32:40 -0800
From:      Navdeep Parhar <nparhar@gmail.com>
To:        Matthew Fleming <matthew.fleming@isilon.com>
Cc:        gnn@freebsd.org, freebsd-stable@freebsd.org
Subject:   Re: LRO support for cxgb in stable/7
Message-ID:  <20091119203240.GA32312@doormat.home>
In-Reply-To: <06D5F9F6F655AD4C92E28B662F7F853E03390417@seaxch09.desktop.isilon.com>
References:  <06D5F9F6F655AD4C92E28B662F7F853E03390417@seaxch09.desktop.isilon.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 19, 2009 at 10:48:40AM -0800, Matthew Fleming wrote:
> r193754 to stable/7 appears to have unintended code.  The MFC note
> indicates it is a backport of 190206, 190330, 192537, 192540, 192584 and
> 192933.  I looked over all of them and none have the offending snippet:
> 
> #ifndef LRO_SUPPORTED
> #ifdef IFCAP_LRO
> #undef IFCAP_LRO
> #endif
> #define IFCAP_LRO 0x0
> #endif
> 
> cxgb had LRO support on releng/7.1 and now it does not, since
> LRO_SUPPORTED is not defined anywhere as a config option, or in the cxgb
> Makefile.
> 
> Is this analysis correct?  Should the above lines be deleted from the
> stable/7 repository?

You're correct.  This has now been fixed in r199544.

Regards,
Navdeep

> 
> Thanks,
> matthew
> _______________________________________________
> freebsd-stable@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-stable
> To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org"



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091119203240.GA32312>