Date: Fri, 17 Sep 2010 19:18:09 -0400 From: jhell <jhell@DataIX.net> To: Wesley Shields <wxs@freebsd.org> Cc: FreeBSD Ports <ports@freebsd.org>, Doug Barton <dougb@freebsd.org> Subject: Re: editors/vim installs to / Message-ID: <4C93F731.6030703@DataIX.net> In-Reply-To: <20100917211919.GA67059@atarininja.org> References: <4C93AA31.5080202@DataIX.net> <20100917211919.GA67059@atarininja.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------030506090807040709090700
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/17/2010 17:19, Wesley Shields wrote:
> On Fri, Sep 17, 2010 at 01:49:37PM -0400, jhell wrote:
>>
>> After a force upgrade of vim that had failed unfortunately not
>> registering the files it installed already I found out that it is
>> installing to / ~!!!!! ugh.
>>
>> Why is ${PREFIX} being used and not ${LOCALBASE} ???
>
> I reverted to the previous Makefile just to get something working before
> I leave. I did want to point out that the cleanup (at least for me) was
> not that hard. /man and /share were left behind along with a handful of
> files in /bin that shouldn't have been there. Once I had reverted and
> installed vim I was able to use something like
>
> pkg_info -L -x vim | fgrep /usr/local/bin | sed -e 's|/usr/local||'
>
> To find the files which were in /bin that should not have been there.
> Not all of them were there in my case but the cleanup was easy. Just
> delete /man and /share and the handful of files in /bin.
>
> I still don't know what the real fix for this is but hopefully someone
> is working on it. ;)
>
> -- WXS
Attached is the exact patch that fixes this. The two effected areas are
post & pre-configure. My best guess on this lays on the REINPLACE_CMD in
pre-configure but I could be wrong.
- --
jhell,v
-----BEGIN PGP SIGNATURE-----
iQEcBAEBAgAGBQJMk/cwAAoJEJBXh4mJ2FR+xukH/2JgWGagRpnvUUjbJfCXetDe
/ahIbbohU+pDmeJ3F6UwcoxPgSd2mW0vRiC+3fFLKi/otAgYqfS+L5X5hMmIoBd1
fgqTeXqy2hF+1IcPdBAIrigxGqv6CA4BmUHYhdMLHV+TVFfboeU70fuBeEYnfsR6
VNYWe8B/0Qb9VNkV+FDFSlvp0Qu4ONkwxPevp/hgTu2914Kd+kmjnLRBTBLekQJ+
KLwXoc1jqoLBwvhT+DRRDFSskNiXjJuAGyt0k10sQpYZCaPwXSXT4mYhjhqDyCnk
uSjxiQe3MK7W1G1QK9RjLOjyMiXbJ8Rv7j6h/pgAoxsegN8xOFryfonRQKp3G44=
=4CXp
-----END PGP SIGNATURE-----
--------------030506090807040709090700
Content-Type: text/x-patch;
name="Makefile.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="Makefile.diff"
--- Makefile.1.357 2010-09-17 18:49:24.188934083 -0400
+++ Makefile 2010-09-17 19:13:22.041265307 -0400
@@ -195,9 +195,6 @@
${REINPLACE_CMD} -e 's,ctags -R \.,${CTAGS_CMD},g')
pre-configure:
- # Fix dependency misspelling so that 'make -j#' will work.
- @${REINPLACE_CMD} -e 's|\./auto/osdef\.h|auto/osdef.h|g' \
- ${WRKSRC}/Makefile
@(cd ${WRKSRC} ; ${MAKE} distclean)
@${REINPLACE_CMD} -e ' \
s|\$$gtk_config_prefix/bin/gtk-config|\$${GTK_CONFIG}|g; \
@@ -210,9 +207,6 @@
${WRKSRC}/feature.h
.endif
-post-configure:
- @(cd ${WRKSRC} ; ${MAKE} scratch config)
-
# Clean up junk files to keep them from being installed.
pre-install:
@${FIND} ${WRKSRC:H} -type f -name '*.orig' -delete
--------------030506090807040709090700
Content-Type: application/octet-stream;
name="Makefile.diff.sig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="Makefile.diff.sig"
iQEcBAABAgAGBQJMk/cxAAoJEJBXh4mJ2FR+mTwH/3oaIgz7HH899YQ2V2PaSVyhC5YnxE7y
2MNguM45Qq7EXvTWuAD00Kxvaaufyiq+vv3dFVeGgNSPu5fiNhwZPC5nON64vgISi8Apsggd
uyljkMqJk8MA5aDHucemOavKwkkGDtX179W2wN9lvCI0oFGy2Y2roNUBNvvEsaNFelw50f1S
5N3VlpgDMTIhoJAq0J/vxpiTSrWxXtRc75GffCpcIOmgiYoitwuUfRJ5avEUDYteGg6Z5etf
4zoWvWKcXLRbRQra+G2PIJxxDxwtuWTTzeWRn0JQ7ncn+14+DXzjIJU618tzManu3Doqd8wT
HbkzLGws2aE16HUas8xXRnA=
--------------030506090807040709090700--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C93F731.6030703>