Date: Fri, 15 Jul 2011 15:57:22 -0600 (MDT) From: Warren Block <wblock@wonkity.com> To: Pav Lucistnik <pav@freebsd.org> Cc: Scot Hetzel <swhetzel@gmail.com>, Stephen Montgomery-Smith <Stephen@freebsd.org>, Stephen Montgomery-Smith <stephen@freebsd.org>, Montgomery-Smith <stephen@missouri.edu>, "freebsd-ports@FreeBSD.org" <freebsd-ports@freebsd.org>, "demon@FreeBSD.org" <demon@freebsd.org>, "lioux@FreeBSD.org" <lioux@freebsd.org>, Jung-uk Kim <jkim@freebsd.org> Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2) Message-ID: <alpine.BSF.2.00.1107151540380.53836@wonkity.com> In-Reply-To: <1310756731.23182.17.camel@hood.oook.cz> References: <201107121826.00020.jkim@FreeBSD.org> <201107131857.36772.jkim@FreeBSD.org> <4E1E9C79.6080105@FreeBSD.org> <4E1F200D.1080002@missouri.edu> <1310666060.23182.1.camel@hood.oook.cz> <CACdU%2Bf9BJg%2BPPA%2Bwv_Pk0UNYkPfbjHeZ8Hibj5eWLFc3ff8WtA@mail.gmail.com> <alpine.BSF.2.00.1107150646540.52034@wonkity.com> <1310756731.23182.17.camel@hood.oook.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---902635197-433808199-1310766544=:53836 Content-Type: TEXT/PLAIN; CHARSET=ISO-8859-15; FORMAT=flowed Content-Transfer-Encoding: 8BIT Content-ID: <alpine.BSF.2.00.1107151551201.53836@wonkity.com> On Fri, 15 Jul 2011, Pav Lucistnik wrote: > Warren Block pí¨e v pá 15. 07. 2011 v 07:15 -0600: > >> It could also be made polymorphic, basing what it does on the >> number of fields rather than a new DESKTOP_ENTRIESv2 define. > > I believe that's impossible because you can create several desktop > entries by repeating the quadruple of values in this variable. > Quite similar to OPTIONS. It would be just like the error check at the start of the routine, look for an even multiple of 6 or 7 fields. But that brings up another problem. All desktop entries would have to be the same type. Can't set the filename for one and leave the others alone. Unless empty fields are used to mean a default filename, and that just makes it more complicated for a rare situation. FWIW, I think the original code with a better regex like Jung-uk Kim has in http://lists.freebsd.org/pipermail/freebsd-ports/2011-July/068737.html is still the way to go. If the port requires a special desktop entry filename, that seems beyond the scope of the DESKTOP_ENTRIES variable. This all should be documented in the Porter's Handbook, and I'll volunteer to work on the DESKTOP_ENTRIES section once there's a decision on the code. ---902635197-433808199-1310766544=:53836--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1107151540380.53836>