From owner-freebsd-net@FreeBSD.ORG  Mon Nov 16 15:09:44 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B093610656A9
	for <freebsd-net@freebsd.org>; Mon, 16 Nov 2009 15:09:44 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from mail-fx0-f227.google.com (mail-fx0-f227.google.com
	[209.85.220.227])
	by mx1.freebsd.org (Postfix) with ESMTP id 494398FC2E
	for <freebsd-net@freebsd.org>; Mon, 16 Nov 2009 15:09:43 +0000 (UTC)
Received: by fxm27 with SMTP id 27so6104907fxm.3
	for <freebsd-net@freebsd.org>; Mon, 16 Nov 2009 07:09:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:sender:received:date
	:x-google-sender-auth:message-id:subject:from:to:content-type;
	bh=z/DChFXiFder2gpjIqNf3bSIOR8Rq08UUrAz+IlVdfM=;
	b=Wdf1Bm9KwFWSf0YqjyVYv6VjRmICf5k/8HVhO0D19L4T1gFRfI/DIFpLQONGx7EQgG
	1Mp2ciwGVnDU8U0AxkW3ubWOLsfhiJF8M+plmnLpakKbtkAIuOkZVFonlVhDGhdmPfbL
	ibdDBBr1D06mCdhqoo/v/6ZoMxVoFWTBMWGog=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:date:x-google-sender-auth:message-id:subject
	:from:to:content-type;
	b=POnGc1zU5sEAQwUU/mnuMSH1IxNAQIFgPV9h2ESy+JNejWJSpKz+xbXCmBER8JQh0l
	m5HqX/AH/N19YE+bfoovq6GDRV9Rnv2n19llxFW+PME6gY3RHEk2wpAzbYnQCKF9R2tC
	qsWDWpZOtk6HuObEOjPxS7G9ZHd3TwoUsah9c=
MIME-Version: 1.0
Sender: asmrookie@gmail.com
Received: by 10.223.6.137 with SMTP id 9mr1212401faz.60.1258384182726; Mon, 16 
	Nov 2009 07:09:42 -0800 (PST)
Date: Mon, 16 Nov 2009 16:09:42 +0100
X-Google-Sender-Auth: 4f5d58773d5fb6f3
Message-ID: <3bbf2fe10911160709h39df3542v49644f11939d80cf@mail.gmail.com>
From: Attilio Rao <attilio@freebsd.org>
To: freebsd-net@freebsd.org,
	=?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@des.no>
Content-Type: text/plain; charset=UTF-8
Cc: 
Subject: [PATCH] Fix a socket leak in libfetch
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Nov 2009 15:09:45 -0000

[Please CC me as I'm not subscribed to -net@]

In ftp_request(), after a successfully established connection,
subsequent errors can bring to a socket leak.
This patch should fix that:
http://www.freebsd.org/~attilio/Sandvine/STABLE_8/libfetch/ftp.diff

This patch has been contributed back by Sandvine Incorporated.
Comments, reviews and testing are welcome.

Thanks,
Attilio


-- 
Peace can only be achieved by understanding - A. Einstein