From owner-svn-src-head@freebsd.org Wed Mar 30 08:55:20 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30534AE03DD for ; Wed, 30 Mar 2016 08:55:20 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: from mail-lb0-x22e.google.com (mail-lb0-x22e.google.com [IPv6:2a00:1450:4010:c04::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE29F1DB2 for ; Wed, 30 Mar 2016 08:55:19 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: by mail-lb0-x22e.google.com with SMTP id bc4so27164755lbc.2 for ; Wed, 30 Mar 2016 01:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+PmXnhONAzH/eW0i4dVH5gl5oGyUWE73JgmMpc6dm50=; b=matxRCxQWWTlgA+z3k51sljrhdV5tQkIFIjpNjMgyXS40M4CC9+UyWTdFZUeicQr/E ojoW8eIpmmGLBMiDHbi4LxNKHZbQNjWKqxcMGfVc4pqlEnykw9MMOBWWU/ULKqedL7n1 CoPaANaRL+u0U6/zlz+V3ZhevVRq0nsCWloefdou/Q43oSiDNF1kQn5nkVAQ7qLVsMgd LT+HHEMC1e4YGTlteIrOdgieFJ5I9KPcJTv3x5EkO5H+JwVv6kWZrRIMHV8Nl2src7ea TPDeeBJiVwQpIziHcuXMdfo8fJX5amK/zxs6+2F6wQy09FFNw6QJVHBBy7iARiW8m8Hb F5Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+PmXnhONAzH/eW0i4dVH5gl5oGyUWE73JgmMpc6dm50=; b=Ik1YDno11LNSiIKBSyGJ2Mg/166Nu98a/Dx+3VlTnzoxm0tzfc34Z+664l/bGkwGMx 9TTl7SY773bbl6ezasJJ93PZKuHaQO/KQ4uRbQNZDoRRBgtAg3G+LhzWbHedHKjxo4/l H1lXxhUQvDh+6B+EP1nbwhtziAdbvUkPc4Ukgv+E/Is3b/XCWIXBC45ZOKRQ3r5O2FYL CAzgyY6YPKTln5j8WW32spR9Sl70TWphkk7xZieuEldxEcwYeqQqAeDhflSIO/o21zdg wc3wZGcEeK23Y02zHfmoel7gl5KpzenDKn6pz03xPDEDSj/4QdDWdIeidYwdMJnnCwig 3sUA== X-Gm-Message-State: AD7BkJKswPneQnJzkqSoDHf8LeUFhKSiHSVUi1Q3o95UC4EmFCJcoDUmFVE6HZt5ISHHS6VsaxToO5w5Vw38+Q== X-Received: by 10.112.148.162 with SMTP id tt2mr2723031lbb.38.1459328118055; Wed, 30 Mar 2016 01:55:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.77.202 with HTTP; Wed, 30 Mar 2016 01:54:58 -0700 (PDT) In-Reply-To: References: <201603291519.u2TFJuXW051571@repo.freebsd.org> From: Zbigniew Bodek Date: Wed, 30 Mar 2016 10:54:58 +0200 Message-ID: Subject: Re: svn commit: r297392 - in head/sys: conf dev/ofw powerpc/mpc85xx powerpc/powermac powerpc/pseries To: Ed Maste Cc: Zbigniew Bodek , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: multipart/mixed; boundary=047d7b3440aa16932e052f404e65 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 08:55:20 -0000 --047d7b3440aa16932e052f404e65 Content-Type: text/plain; charset=UTF-8 Hello Ed, Please check out the attached patch. For powerpc we should compile-in ofwpci.c regardless of FDT option. However, it seems that LINT for powerpc does not have FDT. What do you thing about adding it (as can be seen in the attached patch)?. This would be done in a separate commit. Best regards zbb 2016-03-30 1:53 GMT+02:00 Ed Maste : > On 29 March 2016 at 15:19, Zbigniew Bodek wrote: > > Author: zbb > > Date: Tue Mar 29 15:19:56 2016 > > New Revision: 297392 > > URL: https://svnweb.freebsd.org/changeset/base/297392 > > > > Log: > > Reduce OFW PCI code duplication - involves ARM, PPC and SPARC64 > > My 'make tinderbox' build is now failing (powerpc LINT) with: > > linking kernel > cpcht.o: In function `cpcht_attach': > cpcht.c:(.text+0x17dc): undefined reference to `ofw_pci_attach' > cpcht.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' > grackle.o: In function `grackle_attach': > grackle.c:(.text+0x2dc): undefined reference to `ofw_pci_attach' > grackle.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' > uninorthpci.o: In function `uninorth_attach': > uninorthpci.c:(.text+0x68c): undefined reference to `ofw_pci_attach' > uninorthpci.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' > *** [kernel] Error code 1 > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > --047d7b3440aa16932e052f404e65 Content-Type: text/plain; charset=US-ASCII; name="ppc_lint_fix.diff" Content-Disposition: attachment; filename="ppc_lint_fix.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_imem8px40 ZGlmZiAtLWdpdCBhL3N5cy9jb25mL2ZpbGVzLnBvd2VycGMgYi9zeXMvY29uZi9maWxlcy5wb3dl cnBjCmluZGV4IGUzOTM0M2IuLmQyZThlM2IgMTAwNjQ0Ci0tLSBhL3N5cy9jb25mL2ZpbGVzLnBv d2VycGMKKysrIGIvc3lzL2NvbmYvZmlsZXMucG93ZXJwYwpAQCAtNTcsNyArNTcsNyBAQCBkZXYv b2Z3L29md19jb25zb2xlLmMJCW9wdGlvbmFsCWFpbQogZGV2L29mdy9vZndfZGlzay5jCQlvcHRp b25hbAlvZndkIGFpbQogZGV2L29mdy9vZndfaWljYnVzLmMJCW9wdGlvbmFsCWlpY2J1cyBhaW0K IGRldi9vZncvb2Z3YnVzLmMJCW9wdGlvbmFsCWFpbSB8IGZkdAotZGV2L29mdy9vZndwY2kuYwkJ b3B0aW9uYWwgCWZkdCBwY2kKK2Rldi9vZncvb2Z3cGNpLmMJCW9wdGlvbmFsIAlwY2kKIGRldi9v Zncvb2Z3X3N0YW5kYXJkLmMJCW9wdGlvbmFsCWFpbSBwb3dlcnBjCiBkZXYvb2Z3L29md19zdWJy LmMJCW9wdGlvbmFsCWFpbSBwb3dlcnBjCiBkZXYvcG93ZXJtYWNfbnZyYW0vcG93ZXJtYWNfbnZy YW0uYyBvcHRpb25hbAlwb3dlcm1hY19udnJhbSBwb3dlcm1hYwpkaWZmIC0tZ2l0IGEvc3lzL3Bv d2VycGMvY29uZi9OT1RFUyBiL3N5cy9wb3dlcnBjL2NvbmYvTk9URVMKaW5kZXggNzVlNzc0Zi4u YjAwZGVmNCAxMDA2NDQKLS0tIGEvc3lzL3Bvd2VycGMvY29uZi9OT1RFUworKysgYi9zeXMvcG93 ZXJwYy9jb25mL05PVEVTCkBAIC00Niw2ICs0Niw3IEBAIG9wdGlvbnMgCVBPV0VSTUFDCQkjTmV3 V29ybGQgQXBwbGUgUG93ZXJNYWNzCiBvcHRpb25zIAlQU0lNCQkJI0dEQiBQU0lNIHBwYyBzaW11 bGF0b3IKIG9wdGlvbnMgCU1BTUJPCQkJI0lCTSBNYW1ibyBGdWxsIFN5c3RlbSBTaW11bGF0b3IK IAorb3B0aW9ucyAJRkRUCiBvcHRpb25zIAlTQ19PRldGQgkJIyBPRlcgZnJhbWUgYnVmZmVyCiAK ICMgVGhlIGNwdWZyZXEoNCkgZHJpdmVyIHByb3ZpZGVzIHN1cHBvcnQgZm9yIENQVSBmcmVxdWVu Y3kgY29udHJvbAo= --047d7b3440aa16932e052f404e65--