Date: Wed, 30 Mar 2016 10:54:58 +0200 From: Zbigniew Bodek <zbb@semihalf.com> To: Ed Maste <emaste@freebsd.org> Cc: Zbigniew Bodek <zbb@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r297392 - in head/sys: conf dev/ofw powerpc/mpc85xx powerpc/powermac powerpc/pseries Message-ID: <CAG7dG%2ByBOkHGoTxTWQ436jDpufHeDn3rSS%2B6ZoQCOG7O3HLjCQ@mail.gmail.com> In-Reply-To: <CAPyFy2DCPvQ9ESC8FakSsZ=2kD2YkWieZhJiDC5RieSxFFrKqw@mail.gmail.com> References: <201603291519.u2TFJuXW051571@repo.freebsd.org> <CAPyFy2DCPvQ9ESC8FakSsZ=2kD2YkWieZhJiDC5RieSxFFrKqw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--047d7b3440aa16932e052f404e65 Content-Type: text/plain; charset=UTF-8 Hello Ed, Please check out the attached patch. For powerpc we should compile-in ofwpci.c regardless of FDT option. However, it seems that LINT for powerpc does not have FDT. What do you thing about adding it (as can be seen in the attached patch)?. This would be done in a separate commit. Best regards zbb 2016-03-30 1:53 GMT+02:00 Ed Maste <emaste@freebsd.org>: > On 29 March 2016 at 15:19, Zbigniew Bodek <zbb@freebsd.org> wrote: > > Author: zbb > > Date: Tue Mar 29 15:19:56 2016 > > New Revision: 297392 > > URL: https://svnweb.freebsd.org/changeset/base/297392 > > > > Log: > > Reduce OFW PCI code duplication - involves ARM, PPC and SPARC64 > > My 'make tinderbox' build is now failing (powerpc LINT) with: > > linking kernel > cpcht.o: In function `cpcht_attach': > cpcht.c:(.text+0x17dc): undefined reference to `ofw_pci_attach' > cpcht.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' > grackle.o: In function `grackle_attach': > grackle.c:(.text+0x2dc): undefined reference to `ofw_pci_attach' > grackle.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' > uninorthpci.o: In function `uninorth_attach': > uninorthpci.c:(.text+0x68c): undefined reference to `ofw_pci_attach' > uninorthpci.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' > *** [kernel] Error code 1 > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > --047d7b3440aa16932e052f404e65 Content-Type: text/plain; charset=US-ASCII; name="ppc_lint_fix.diff" Content-Disposition: attachment; filename="ppc_lint_fix.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_imem8px40 ZGlmZiAtLWdpdCBhL3N5cy9jb25mL2ZpbGVzLnBvd2VycGMgYi9zeXMvY29uZi9maWxlcy5wb3dl cnBjCmluZGV4IGUzOTM0M2IuLmQyZThlM2IgMTAwNjQ0Ci0tLSBhL3N5cy9jb25mL2ZpbGVzLnBv d2VycGMKKysrIGIvc3lzL2NvbmYvZmlsZXMucG93ZXJwYwpAQCAtNTcsNyArNTcsNyBAQCBkZXYv b2Z3L29md19jb25zb2xlLmMJCW9wdGlvbmFsCWFpbQogZGV2L29mdy9vZndfZGlzay5jCQlvcHRp b25hbAlvZndkIGFpbQogZGV2L29mdy9vZndfaWljYnVzLmMJCW9wdGlvbmFsCWlpY2J1cyBhaW0K IGRldi9vZncvb2Z3YnVzLmMJCW9wdGlvbmFsCWFpbSB8IGZkdAotZGV2L29mdy9vZndwY2kuYwkJ b3B0aW9uYWwgCWZkdCBwY2kKK2Rldi9vZncvb2Z3cGNpLmMJCW9wdGlvbmFsIAlwY2kKIGRldi9v Zncvb2Z3X3N0YW5kYXJkLmMJCW9wdGlvbmFsCWFpbSBwb3dlcnBjCiBkZXYvb2Z3L29md19zdWJy LmMJCW9wdGlvbmFsCWFpbSBwb3dlcnBjCiBkZXYvcG93ZXJtYWNfbnZyYW0vcG93ZXJtYWNfbnZy YW0uYyBvcHRpb25hbAlwb3dlcm1hY19udnJhbSBwb3dlcm1hYwpkaWZmIC0tZ2l0IGEvc3lzL3Bv d2VycGMvY29uZi9OT1RFUyBiL3N5cy9wb3dlcnBjL2NvbmYvTk9URVMKaW5kZXggNzVlNzc0Zi4u YjAwZGVmNCAxMDA2NDQKLS0tIGEvc3lzL3Bvd2VycGMvY29uZi9OT1RFUworKysgYi9zeXMvcG93 ZXJwYy9jb25mL05PVEVTCkBAIC00Niw2ICs0Niw3IEBAIG9wdGlvbnMgCVBPV0VSTUFDCQkjTmV3 V29ybGQgQXBwbGUgUG93ZXJNYWNzCiBvcHRpb25zIAlQU0lNCQkJI0dEQiBQU0lNIHBwYyBzaW11 bGF0b3IKIG9wdGlvbnMgCU1BTUJPCQkJI0lCTSBNYW1ibyBGdWxsIFN5c3RlbSBTaW11bGF0b3IK IAorb3B0aW9ucyAJRkRUCiBvcHRpb25zIAlTQ19PRldGQgkJIyBPRlcgZnJhbWUgYnVmZmVyCiAK ICMgVGhlIGNwdWZyZXEoNCkgZHJpdmVyIHByb3ZpZGVzIHN1cHBvcnQgZm9yIENQVSBmcmVxdWVu Y3kgY29udHJvbAo= --047d7b3440aa16932e052f404e65--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG7dG%2ByBOkHGoTxTWQ436jDpufHeDn3rSS%2B6ZoQCOG7O3HLjCQ>