From owner-svn-src-all@FreeBSD.ORG  Tue Jun  9 11:13:54 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 888E3283;
 Tue,  9 Jun 2015 11:13:54 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 355211D40;
 Tue,  9 Jun 2015 11:13:52 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA23581;
 Tue, 09 Jun 2015 14:13:50 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1Z2HTa-0009be-I0; Tue, 09 Jun 2015 14:13:50 +0300
Message-ID: <5576CA36.8060403@FreeBSD.org>
Date: Tue, 09 Jun 2015 14:12:54 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Jan Beich <jbeich@FreeBSD.org>
CC: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
 svn-src-head@FreeBSD.org
Subject: Re: svn commit: r284107 - head/sys/cddl/compat/opensolaris/sys
References: <201506070854.t578sPdR012092@svn.freebsd.org>
 <twuh-9nr0-wny@FreeBSD.org>
In-Reply-To: <twuh-9nr0-wny@FreeBSD.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jun 2015 11:13:54 -0000

On 09/06/2015 13:31, Jan Beich wrote:
> Andriy Gapon <avg@FreeBSD.org> writes:
> 
>> Author: avg Date: Sun Jun  7 08:54:25 2015 New Revision: 284107 URL:
>> https://svnweb.freebsd.org/changeset/base/284107
>> 
>> Log: compat nvpair.h: make sure that the names are mangled only for
>> kernel
>> 
>> Currently there is no good reason to mangle the userland API. The change
>> was introduced in eac1d566b46edef765754203bef22c75c1699966, r279437.
>> Also see https://reviews.freebsd.org/D1881.
> 
> Can you bump __FreeBSD_version? At least sysutils/geomWatch requires it.
> 
> https://svnweb.freebsd.org/changeset/ports/388906
> 

There should have been a bug report and an src fix instead of (parts of)
https://svnweb.freebsd.org/ports?view=revision&revision=386870

I wonder why the libnvpair ABI breakage was silently accepted but the ABI fix
requires some special magic...

-- 
Andriy Gapon