From owner-freebsd-ports@FreeBSD.ORG Fri Dec 23 00:45:10 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id EB7F5106564A for ; Fri, 23 Dec 2011 00:45:10 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 6192B1524D6; Fri, 23 Dec 2011 00:45:05 +0000 (UTC) Message-ID: <4EF3CF11.6070104@FreeBSD.org> Date: Thu, 22 Dec 2011 16:45:05 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111110 Thunderbird/8.0 MIME-Version: 1.0 To: Christer Edwards References: <4EEC6D9D.1020102@yandex.ru> <4EEEAE03.1080908@yandex.ru> <4EF2FBAE.8050406@yandex.ru> <4EF393BC.2020003@yandex.ru> In-Reply-To: X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: multipart/mixed; boundary="------------000907000605080900050601" Cc: "freebsd-ports@FreeBSD.org" , Ruslan Mahmatkhanov Subject: salt rc.d scripts (Was: RUN_DEPENDS for python based port) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2011 00:45:11 -0000 This is a multi-part message in MIME format. --------------000907000605080900050601 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 12/22/2011 16:32, Christer Edwards wrote: > I must have horrible luck or something, but I've put together rc > scripts and they don't work. This port sure is giving me a hard time! > > Here is a link to the updated archive with the .sample suggestions > applied as well as the rc scripts. Can anyone see what is wrong with > them? I simply get complains that it isn't toggled to YES in the > rc.conf, but it is.. Can you paste the actual error that you're getting, and the output of 'grep salt /etc/rc.conf /etc/rc.conf.local' please? I reviewed your scripts, and there is nothing that should cause the error you're describing. I even tried with and without salt_master_enable in rc.conf and got the expected results for both. There are some style problems and one real bug that are repeated for all 3 scripts. I attached a fixed version of one of them, hopefully that will help you see what's needed to fix the other 2. Also, please review http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html, especially the pre-commit checklist. hth, Doug -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ --------------000907000605080900050601 Content-Type: text/plain; name="salt-master.in" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="salt-master.in" #!/bin/sh # $FreeBSD$ # # Salt Master startup script # # PROVIDE: salt-master # REQUIRE: LOGIN # KEYWORD: shutdown # # Add the following to /etc/rc.conf[.local] to enable this service # # salt_master_enable="YES" . /etc/rc.subr name="salt-master" rcvar="salt_master_enable" load_rc_config ${name} : ${salt_master_enable:="NO"} command="%%PREFIX%%/bin/${name}" pidfile="/var/run/${name}.pid" required_files="%%PREFIX%%/etc/salt/master" command_args="-c $required_files -d" run_rc_command "$1" --------------000907000605080900050601--