From owner-cvs-all  Wed Feb 21  4:25:37 2001
Delivered-To: cvs-all@freebsd.org
Received: from blizzard.sabbo.net (pop3.sabbo.net [193.193.218.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2D35A37B401; Wed, 21 Feb 2001 04:25:04 -0800 (PST)
	(envelope-from sobomax@FreeBSD.org)
Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112])
	by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f1LCORD24052;
	Wed, 21 Feb 2001 14:24:36 +0200
Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1])
	by vic.sabbo.net (8.11.2/8.11.2) with ESMTP id f1LCOQr00899;
	Wed, 21 Feb 2001 14:24:26 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <3A93B384.D51AB1AA@FreeBSD.org>
Date: Wed, 21 Feb 2001 14:24:36 +0200
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Vega International Capital
X-Mailer: Mozilla 4.76 [en] (WinNT; U)
X-Accept-Language: uk,ru,en
MIME-Version: 1.0
To: Peter Pentchev <roam@orbitel.bg>
Cc: Ben Smithurst <ben@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/share/man/man9 style.9
References: <200102211210.f1LCAKN41997@freefall.freebsd.org> <20010221141342.A98551@ringworld.oblivion.bg>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Peter Pentchev wrote:

> On Wed, Feb 21, 2001 at 04:10:19AM -0800, Ben Smithurst wrote:
> > ben         2001/02/21 04:10:19 PST
> >
> >   Modified files:
> >     share/man/man9       style.9
> >   Log:
> >   Don't suggest
> >
> >       if (error = function(a1, a2))
> >
> >   since it causes a warning with -Wall.  Change it so it has an explicit test
> >   against zero,
> >
> >       if ((error = function(a1, a2)) != 0)
>
> I've sometimes seen tests like:
>
>         if (error = function(a1, a2), error != 0)
>
> Is this not a bit clearer?

I don't think so.

-Maxim


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message