From owner-freebsd-net Mon Oct 14 14:23:11 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BEA2637B401; Mon, 14 Oct 2002 14:23:09 -0700 (PDT) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11D6643EAA; Mon, 14 Oct 2002 14:23:09 -0700 (PDT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.9.3/8.9.3) with ESMTP id RAA06015; Mon, 14 Oct 2002 17:23:08 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.11.6/8.9.1) id g9ELMcc54226; Mon, 14 Oct 2002 17:22:38 -0400 (EDT) (envelope-from gallatin@cs.duke.edu) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15787.13726.246550.526201@grasshopper.cs.duke.edu> Date: Mon, 14 Oct 2002 17:22:38 -0400 (EDT) To: John Baldwin Cc: net@FreeBSD.org Subject: Re: Rename of MSIZE kernel option.. In-Reply-To: References: X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org John Baldwin writes: > Would people be open to renaming the 'MSIZE' kernel option to something > more specific such as 'MBUF_SIZE' or 'MBUFSIZE'? Using 'MSIZE' can No. MSIZE is a traditional BSDism. Everybody else still uses it. Even AIX and MacOS. I really don't like the idea of changing this. > break other places in the kernel. For example, ISA device ivars have > an ivar for the size of a memory resource called 'MSIZE' and the kernel > option causes breakage in src/sys/isa/isavar.h: > > ISA_ACCESSOR(msize, MSIZE, int) > > when ISA_ACCESSOR is properly defined via __BUS_ACCESSOR() rather than > homerolling a private copy of __BUS_ACCESSOR(). For now I've fixed it > to rename the ISA ivar to ISA_IVAR_MEMSIZE but MSIZE seems to be too > generic a name for a kernel option and it would be nice to avoid this > problem in the future. Renaming MSIZE to ISA_IVAR_MEMSIZE seems right to me. Drew To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message