From owner-cvs-all Wed Apr 5 23:46:26 2000 Delivered-To: cvs-all@freebsd.org Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by hub.freebsd.org (Postfix) with ESMTP id 4D5EF37B910; Wed, 5 Apr 2000 23:46:17 -0700 (PDT) (envelope-from grog@freebie.lemis.com) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id QAA75659; Thu, 6 Apr 2000 16:16:04 +0930 (CST) Date: Thu, 6 Apr 2000 16:16:04 +0930 From: Greg Lehey To: Soren Schmidt Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum vinuminterrupt.c Message-ID: <20000406161604.J73669@freebie.lemis.com> References: <200004060303.UAA06576@freefall.freebsd.org> <200004060641.IAA90179@freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Mailer: Mutt 1.0pre2i In-Reply-To: <200004060641.IAA90179@freebsd.dk> WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thursday, 6 April 2000 at 8:41:49 +0200, Søren Schmidt wrote: > It seems Greg Lehey wrote: >> grog 2000/04/05 20:03:32 PDT >> >> Modified files: >> sys/dev/vinum vinuminterrupt.c >> Log: >> complete_rqe: Remove a race condition in RAID-4 and RAID-5 where a >> request could be deallocated before the top half had finished >> issuing it. The problem seems only to happen with IDE drives >> and vn devices, but theoretically it could happen with any >> drive. This is the most important part of a possible series >> of fixes designed to remove race conditions without locking >> out interrupts for longer than absolutely necessary. >> >> Reported-by: sos >> Fix-supplied-by: dillon > > > Cool!, I'll throw my server at it as soon as I get home today... Good. I'm not 100% sure that this fix alone will work, but I don't want to overdo things, because it can have an adverse effect on performance. I'll do some tests on vnode devices here; that should have the same effect. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message