From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Jan 19 13:40:07 2009
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A14EA106566B
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Mon, 19 Jan 2009 13:40:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 8F85A8FC1A
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Mon, 19 Jan 2009 13:40:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n0JDe7Kw080080
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Mon, 19 Jan 2009 13:40:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n0JDe7ft080073;
	Mon, 19 Jan 2009 13:40:07 GMT (envelope-from gnats)
Date: Mon, 19 Jan 2009 13:40:07 GMT
Message-Id: <200901191340.n0JDe7ft080073@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Alexander Kriventsov <akriventsov@masterhost.ru>
Cc: 
Subject: Re: ports/130647: devel/p5-File-Pid: uninitialized value warning
 if you call running without an existing pid file
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Alexander Kriventsov <akriventsov@masterhost.ru>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jan 2009 13:40:07 -0000

The following reply was made to PR ports/130647; it has been noted by GNATS.

From: Alexander Kriventsov <akriventsov@masterhost.ru>
To: bug-followup@FreeBSD.org, akriventsov@masterhost.ru
Cc:  
Subject: Re: ports/130647: devel/p5-File-Pid: uninitialized value warning
 if you call running without an existing pid file
Date: Mon, 19 Jan 2009 16:08:58 +0300

 Sorry, correct patch is
 
 diff -r -u -B -N p5-File-Pid.orig/Makefile p5-File-Pid/Makefile
 --- p5-File-Pid.orig/Makefile   2008-04-17 14:25:25.000000000 +0000
 +++ p5-File-Pid/Makefile        2009-01-17 10:48:03.613381790 +0000
 @@ -7,6 +7,7 @@
 
   PORTNAME=      File-Pid
   PORTVERSION=   1.01
 +PORTREVISION=  1
   CATEGORIES=    devel perl5
   MASTER_SITES=  CPAN
   PKGNAMEPREFIX= p5-
 @@ -21,4 +22,7 @@
 
   MAN3=          File::Pid.3
 
 +post-patch:
 +       ${RM} ${WRKSRC}/lib/File/Pid.pm.orig
 +
   .include <bsd.port.mk>
 diff -r -u -B -N p5-File-Pid.orig/files/patch-lib-File-Pid.pm 
 p5-File-Pid/files/patch-lib-File-Pid.pm
 --- p5-File-Pid.orig/files/patch-lib-File-Pid.pm        1970-01-01 
 00:00:00.000000000 +0000
 +++ p5-File-Pid/files/patch-lib-File-Pid.pm     2009-01-17 
 10:11:50.058553176 +0000
 @@ -0,0 +1,11 @@
 +--- lib/File/Pid.pm    2009-01-17 09:44:31.653906918 +0000
 ++++ lib/File/Pid.pm    2009-01-17 09:44:01.397399415 +0000
 +@@ -119,7 +119,7 @@
 +
 + sub running {
 +     my $self = shift;
 +-    my $pid  = $self->_get_pid_from_file;
 ++    my $pid  = $self->_get_pid_from_file or return undef;
 +
 +     return   kill(0, $pid)
 +            ? $pid
 
 -- 
 Best Regards,
 Alexander Kriventsov
 .masterhost