Date: Mon, 22 Apr 2019 15:02:17 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 236944] security/strongswan: startup script improvements Message-ID: <bug-236944-7788-cjsI8EDBZZ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-236944-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-236944-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236944 Sam Chen <sc.gear@one.caeon.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sc.gear@one.caeon.com --- Comment #5 from Sam Chen <sc.gear@one.caeon.com> --- Hi Jose, thanks for making the code better. Small observations and suggestions, if you will: 1) check_charon() - Consider rc.subr err() to throw messages. Why exit cod= e 7 ? Since "swanctl --stats" sets errno 61 on VICI socket failure. 2) wait_charon() - Consider hard-code the wait interval (e.g. "sleep 5"). = Else while loop runs command "sleep 1" five times when $charon_pidfile exists. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-236944-7788-cjsI8EDBZZ>