From owner-cvs-src@FreeBSD.ORG  Wed Apr 30 02:10:31 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 833AD37B401; Wed, 30 Apr 2003 02:10:31 -0700 (PDT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 098DD43FB1; Wed, 30 Apr 2003 02:10:30 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h3U9A3s4006555;
	Wed, 30 Apr 2003 11:10:07 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: Harti Brandt <brandt@fokus.fraunhofer.de>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 30 Apr 2003 09:43:32 +0200."
             <20030430093931.V31027@beagle.fokus.fraunhofer.de> 
Date: Wed, 30 Apr 2003 11:10:03 +0200
Message-ID: <6554.1051693803@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: "M. Warner Losh" <imp@bsdimp.com>
cc: nate@root.org
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Apr 2003 09:10:32 -0000

In message <20030430093931.V31027@beagle.fokus.fraunhofer.de>, Harti Brandt wri
tes:
>On Tue, 29 Apr 2003, M. Warner Losh wrote:
>
>MWL>In message: <Pine.BSF.4.21.0304291101001.75697-100000@root.org>
>
>MWL>: >           4) Return immediately if gone is true in fxp_ioctl
>MWL>: >           5) Return immediately if gone is true in fxp_intr
>MWL>:
>MWL>: Not sure this approach is necessary.
>MWL>
>MWL>I am.  Otherwise ioctl panics with recursive locks when the card is
>MWL>detached.  A simple kld_unload if_fxp would provoke these races,
>MWL>including the recursive lock panic.
>
>You can replace the pointers to ioctl and start with pointers to dummy
>functions. In fact, an if_dead(ifp) function which does just this would
>be nice to have.

isn't that what if_disc.c does already ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.