From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jan 27 10:40:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2585216A41B for ; Sun, 27 Jan 2008 10:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0270413C45B for ; Sun, 27 Jan 2008 10:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0RAe1GX088522 for ; Sun, 27 Jan 2008 10:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0RAe1vw088521; Sun, 27 Jan 2008 10:40:01 GMT (envelope-from gnats) Resent-Date: Sun, 27 Jan 2008 10:40:01 GMT Resent-Message-Id: <200801271040.m0RAe1vw088521@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rong-En Fan Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55A9816A418; Sun, 27 Jan 2008 10:32:35 +0000 (UTC) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (svm.csie.ntu.edu.tw [140.112.90.75]) by mx1.freebsd.org (Postfix) with ESMTP id 0046413C45A; Sun, 27 Jan 2008 10:32:34 +0000 (UTC) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (localhost [127.0.0.1]) by svm.csie.ntu.edu.tw (8.14.1/8.14.1) with ESMTP id m0RAA8sR013268; Sun, 27 Jan 2008 18:10:08 +0800 (CST) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: (from rafan@localhost) by svm.csie.ntu.edu.tw (8.14.1/8.14.1/Submit) id m0RAA8th041534; Sun, 27 Jan 2008 18:10:08 +0800 (CST) (envelope-from rafan) Message-Id: <200801271010.m0RAA8th041534@svm.csie.ntu.edu.tw> Date: Sun, 27 Jan 2008 18:10:08 +0800 (CST) From: Rong-En Fan To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: cjh@FreeBSD.org Subject: ports/120033: [PATCH] print/magicfilter: Use sysutils/file if it exists X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jan 2008 10:40:02 -0000 >Number: 120033 >Category: ports >Synopsis: [PATCH] print/magicfilter: Use sysutils/file if it exists >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Jan 27 10:40:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Rong-En Fan >Release: FreeBSD 6.3-PRERELEASE amd64 >Organization: NTU CSIE >Environment: >Description: In ports/96495, I make this port depends on sysutils/file unconditionally as at that time our libmagic in base is too old. However, the situation changes now, our libmagic in 6.x to 8.x are new enough. And, with unknown reason that with new X11BASE=LOCALBASE environment, magicfilter can not correctly recognize file format when linking to sysutils/file. So I think it's better to make magicfilter uses sysutils/file only if it's installed. Port maintainer (cjh@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.77 >How-To-Repeat: >Fix: --- magicfilter-2.3.h_2.patch begins here --- Index: Makefile =================================================================== RCS file: /home/ncvs/ports/print/magicfilter/Makefile,v retrieving revision 1.18 diff -u -u -r1.18 Makefile --- Makefile 24 Sep 2007 08:39:23 -0000 1.18 +++ Makefile 27 Jan 2008 10:06:04 -0000 @@ -7,17 +7,13 @@ PORTNAME= magicfilter PORTVERSION= 2.3.h -PORTREVISION= 1 -PORREVISION= 1 +PORTREVISION= 2 CATEGORIES= print MASTER_SITES= http://www.pell.portland.or.us/~orc/Code/magicfilter/ MAINTAINER= cjh@FreeBSD.org COMMENT= Customizable, extensible automatic printer filter -BUILD_DEPENDS= ${LOCALBASE}/lib/libmagic.so:${PORTSDIR}/sysutils/file -RUN_DEPENDS= ${BUILD_DEPENDS} - USE_GHOSTSCRIPT= yes GNU_CONFIGURE= yes @@ -30,4 +26,11 @@ MAN5= magicfilter.5 MAN8= magicfilter.8 -.include +.include + +.if exists(${LOCALBASE}/lib/libmagic.so) +BUILD_DEPENDS+= ${LOCALBASE}/lib/libmagic.so:${PORTSDIR}/sysutils/file +RUN_DEPENDS+= ${BUILD_DEPENDS} +.endif + +.include --- magicfilter-2.3.h_2.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: