From owner-svn-ports-head@freebsd.org  Mon Dec 18 03:39:33 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D8DAFE9F898;
 Mon, 18 Dec 2017 03:39:33 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id BAD5E68E31;
 Mon, 18 Dec 2017 03:39:33 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id DFD54259E; Mon, 18 Dec 2017 03:39:32 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Mark Linimon <linimon@FreeBSD.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
Subject: Re: svn commit: r456578 - head/biology/hmmer
References: <201712180232.vBI2WlFi034525@repo.freebsd.org>
 <zi6g-u2w7-wny@FreeBSD.org>
Date: Mon, 18 Dec 2017 04:39:26 +0100
In-Reply-To: <zi6g-u2w7-wny@FreeBSD.org> (Jan Beich's message of "Mon, 18 Dec
 2017 04:32:40 +0100")
Message-ID: <fu88-u2kx-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Dec 2017 03:39:33 -0000

Jan Beich <jbeich@FreeBSD.org> writes:

> +CONFIGURE_ARGS_i386=	${"${MACHINE_CPU:Msse2}":?:"--disable-sse"}
[...]
> +PLIST_SUB_i386=	IMPL_CHOICE=${"${MACHINE_CPU:Msse2}":?"sse":"dummy"}

Oops, :? make(1) modifier only needs variable quoted, not replacements strings.
The following would've been more correct.

CONFIGURE_ARGS_i386=	${"${MACHINE_CPU:Msse2}":?:--disable-sse}
PLIST_SUB_i386=	IMPL_CHOICE=${"${MACHINE_CPU:Msse2}":?sse:dummy}