From owner-cvs-src@FreeBSD.ORG Wed Nov 30 19:41:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1009F16A42C; Wed, 30 Nov 2005 19:41:43 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0F1443D6A; Wed, 30 Nov 2005 19:41:32 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id CB7A152C70; Wed, 30 Nov 2005 20:41:23 +0100 (CET) Received: from localhost (dkx48.neoplus.adsl.tpnet.pl [83.24.27.48]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id C8F4650B83; Wed, 30 Nov 2005 20:41:17 +0100 (CET) Date: Wed, 30 Nov 2005 20:40:40 +0100 From: Pawel Jakub Dawidek To: Maxim Sobolev Message-ID: <20051130194039.GI79912@garage.freebsd.pl> References: <200511301924.jAUJOpHL061333@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="37nyS7qXrnu4wN2o" Content-Disposition: inline In-Reply-To: <200511301924.jAUJOpHL061333@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/mirror g_mirror.c src/sys/geom/vinum geom_vinum_drive.c src/sys/geom/label g_label_iso9660.c g_label_msdosfs.c g_label_ufs.c src/sys/geom/raid3 g_raid3.c src/sys/geom/uzip g_uzip.c src/sys/geom/eli g_eli.c src/sys/geom ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2005 19:41:43 -0000 --37nyS7qXrnu4wN2o Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 30, 2005 at 07:24:51PM +0000, Maxim Sobolev wrote: +> sobomax 2005-11-30 19:24:51 UTC +>=20 +> FreeBSD src repository +>=20 +> Modified files: +> sys/geom/mirror g_mirror.c=20 +> sys/geom/vinum geom_vinum_drive.c=20 +> sys/geom/label g_label_ufs.c g_label_iso9660.c=20 +> g_label_msdosfs.c=20 +> sys/geom/raid3 g_raid3.c=20 +> sys/geom/uzip g_uzip.c=20 +> sys/geom/eli g_eli.c=20 +> sys/geom geom_aes.c geom_apple.c geom_bsd.c=20 +> geom_fox.c geom_gpt.c geom_mbr.c=20 +> geom_pc98.c geom_sunlabel.c=20 +> geom_vol_ffs.c=20 +> Log: +> Check for g_read_data(9) errors properly: +> =20 +> o The only indication of error condition is NULL value returned by +> the function; +> =20 +> o value pointed to by error argument is undefined in the case when +> operation completes successfully. If you decided to clean this up, please make it a complete clean-up, so noone has to clean up after you:) The thing I'm talking about is that when you don't plan to use error value, you can just pass NULL as the last argument for g_read_data(9). There are probably few places now where 'error' variable is unused. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --37nyS7qXrnu4wN2o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDjgA3ForvXbEpPzQRAvVEAKDAT3oerbJybZE3i1PpknKPOO0OrQCdGrs5 2Hqjp4KRhLJW969YvGFuzUM= =WeCu -----END PGP SIGNATURE----- --37nyS7qXrnu4wN2o--