From owner-svn-ports-all@freebsd.org Sun Feb 14 20:41:53 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE4AD53B55F; Sun, 14 Feb 2021 20:41:53 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from smtp.burggraben.net (smtp.burggraben.net [IPv6:2a01:4f8:140:510a::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.burggraben.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ddzg54QvYz4X0g; Sun, 14 Feb 2021 20:41:53 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from elch.exwg.net (elch.exwg.net [IPv6:2001:470:7120:1:127b:44ff:fe4f:148d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "elch.exwg.net", Issuer "R3" (verified OK)) by smtp.burggraben.net (Postfix) with ESMTPS id D1CE4C0030F; Sun, 14 Feb 2021 21:41:49 +0100 (CET) Received: by elch.exwg.net (Postfix, from userid 1000) id 7B8CC139857; Sun, 14 Feb 2021 21:41:49 +0100 (CET) Date: Sun, 14 Feb 2021 21:41:49 +0100 From: Christoph Moench-Tegeder To: Jason Bacon Cc: "Jason W. Bacon" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r565224 - in head/lang/pocl: . files Message-ID: References: <202102141304.11ED4BTl046406@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) X-Rspamd-Queue-Id: 4Ddzg54QvYz4X0g X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2021 20:41:53 -0000 ## Jason Bacon (bacon4000@gmail.com): > > First, while I'm all in favor of consistent white space, mixing this > > with the stated (per commit message) change makes the diff harder > > to read and "svn annotate" (and similar tools) harder to use later on. > Are you suggesting that whitespace changes should be done in a separate > commit? Perhaps I wouldn't put it that strongly. More like "think about how that looks like in the commit history". This is not a policy, but some options: - if you're changing a line anyways, fix the whitespace there at the same time - lines which will never or rarely change (PORTNAME, MAINTAINER, ...) could be whitespace-fixed in their own commit - fix the whitespace across the whole file first, then do whatever "real" change you want to do - depending on how much you change anyways, it might even not matter that much if you "just fix the whitespace on the side". The guiding principle should be to retain the usefulness of the commit diffs and the history: searching that one "real" change in dozens of lines of whitespace-only diff can be frustrating, and running "{svn,git} annotate" just to end up at that one "fix whitespace" commit also does not help. Regards, Christoph -- Spare Space