From owner-cvs-all  Thu Apr 23 05:47:48 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id FAA24958
          for cvs-all-outgoing; Thu, 23 Apr 1998 05:47:48 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from ns1.yes.no (ns1.yes.no [195.119.24.10])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA24949
          for <cvs-committers@FreeBSD.ORG>; Thu, 23 Apr 1998 05:47:46 -0700 (PDT)
          (envelope-from eivind@bitbox.follo.net)
Received: from bitbox.follo.net (bitbox.follo.net [194.198.43.36])
	by ns1.yes.no (8.8.7/8.8.7) with ESMTP id MAA28408;
	Thu, 23 Apr 1998 12:47:44 GMT
Received: (from eivind@localhost)
	by bitbox.follo.net (8.8.8/8.8.6) id OAA03023;
	Thu, 23 Apr 1998 14:47:43 +0200 (MET DST)
Message-ID: <19980423144743.33016@follo.net>
Date: Thu, 23 Apr 1998 14:47:43 +0200
From: Eivind Eklund <eivind@yes.no>
To: Peter Dufault <dufault@hda.com>
Cc: cvs-committers@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/sys time.h
References: <19980423130550.30970@follo.net> <199804231236.IAA23320@hda.hda.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.89.1i
In-Reply-To: <199804231236.IAA23320@hda.hda.com>; from Peter Dufault on Thu, Apr 23, 1998 at 08:36:32AM -0400
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

On Thu, Apr 23, 1998 at 08:36:32AM -0400, Peter Dufault wrote:
> > On Thu, Apr 23, 1998 at 01:36:19PM +1000, Bruce Evans wrote:
> > > >eivind      1998/04/22 17:11:32 PDT
> > > >
> > > >  Modified files:
> > > >    sys/sys              time.h 
> > > >  Log:
> > > >  Wrap timerclear in do { ... } while(0)
> > > 
> > > Wrong fix.  The do-while(0) hack is bogus for macros that expand to an
> > > expression.
> > 
> > I strongly  disagree.  Such macros should most definately have
> > do { ... } while(0) protection, to avoid people depending on the fact
> > that they just happen to be expressions.  Otherwise, we're inviting
> > people to depend on implementation details.
> 
> Given no specification for timerclear pre-existing behavior
> should be maintained.

Pre-existing behaviour was added two weeks ago, and was wrong at that
point (a non-parenthesized expression).  I did the change the day
after the original code was committed, but had it in my tree for a
while before committing it.

> Given a specification that says it behaves as if it returns void
> you're right.

AFAIK, the only specification for timerclear() is the code.  The code
says it returns void.  Happy?  ;-)

Eivind.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message