From owner-svn-src-head@freebsd.org Mon Jun 11 20:17:40 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 042EF1014C28 for ; Mon, 11 Jun 2018 20:17:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 812B77B90B for ; Mon, 11 Jun 2018 20:17:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x230.google.com with SMTP id d22-v6so25382787iof.13 for ; Mon, 11 Jun 2018 13:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=d5P1mBDVhvPYaqjhaNSHw9yml0Ac/tohChPQD8ABZdo=; b=fj/X06+5dJSDTSbAPvmU6AqlJ0YLn8n0hWZ6gEPswdI0qcloyYVLICjMPzyLYZVBCJ 4M5OZ4OTfzG7ciBZk9gm8itI/xA4dCXNO5JCVlMBl3RIZlUG306KGLoukvq6rWWONnLA ZxxE7fnMDfoY/VlGUmb+KPXK0BvWYKUdcFWiGDEqIdP54ZLzf+F+R3HYEpFL6kk5f7Y5 Am5eTGRWNwQu+abP4NFYZntbH9XbOs5gbsJrx1XGdsxg+++cKIkcQW5dExEt7wpGfSLX S3K8tH7y+1lHVQWXHg5OlS+Ndc3ZHrjV1497gjrW8rrFKhvH596lsPYY9yJvOr5lf6Rl 8K2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=d5P1mBDVhvPYaqjhaNSHw9yml0Ac/tohChPQD8ABZdo=; b=DNq4BqKeK/j9adn/1cWmDsiRODtxp2Agsc4gSHoYbx8ZNUwUS4b0LeCn/BRmTTjREn 4oK4Z7AGMj7sjZd9mXsoj/dcjD4NoMLaLs97wNul/jAdCDRN9MVJdTUPPKFYs1LNwfHH TsRs+2sss+6ux47GoRfkgOCWjGr98xXewi3O7v6WG5R1m2KuSERM95wkUqv3dC9U/dog kNPIFxoUqbMhgolvFv4+NT7ZcQd9b+oCGLX6xxTngFVRZcdetU6bIEExtEKiMm3EjwUm PINp8W53BpYlLVYe79H7iq/fnP9KxGgQXNA9fSeQxXJSrhjQvKhZVy0IP36ys0Xw+rRs fWLg== X-Gm-Message-State: APt69E04On9pXc87+A3IaMrFilBb3Jqeh+JXbMbKOqjYMZDzApoUaK2J U+c8QFhlVr2wX7ys8cKGfpDxcLo53A0OInMbzT+JrQ== X-Google-Smtp-Source: ADUXVKIuX7hStAE5GuGCtluK/ztz+Cazvqshoj077kBMaUv0wxawukBhe9PVL3TrIwJZKAyzdRJpbEs4ydU/2WRORx0= X-Received: by 2002:a6b:be01:: with SMTP id o1-v6mr600032iof.299.1528748258740; Mon, 11 Jun 2018 13:17:38 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:d028:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 13:17:38 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <201806112001.w5BK1mGk029844@pdx.rh.CN85.dnsmgr.net> References: <201806112001.w5BK1mGk029844@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Mon, 11 Jun 2018 14:17:38 -0600 X-Google-Sender-Auth: JDGIWVtIeu3Ja0ow91OdIpUflfg Message-ID: Subject: Re: svn commit: r334970 - head To: "Rodney W. Grimes" Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 20:17:40 -0000 On Mon, Jun 11, 2018 at 2:01 PM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > On Mon, Jun 11, 2018 at 1:52 PM, Rodney W. Grimes < > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > [ Charset UTF-8 unsupported, converting... ] > > > > Author: imp > > > > Date: Mon Jun 11 19:32:40 2018 > > > > New Revision: 334970 > > > > URL: https://svnweb.freebsd.org/changeset/base/334970 > > > > > > > > Log: > > > > Document the dump issue in UPDATING so people understand when they > > > > get a new diagnostic. > > > > > > > > Modified: > > > > head/UPDATING > > > > > > > > Modified: head/UPDATING > > > > ============================================================ > > > ================== > > > > --- head/UPDATING Mon Jun 11 19:32:36 2018 (r334969) > > > > +++ head/UPDATING Mon Jun 11 19:32:40 2018 (r334970) > > > > @@ -32,6 +32,13 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 12.x IS > SLOW: > > > > "ln -s 'abort:false,junk:false' /etc/malloc.conf".) > > > > > > > > > > > > +20180611: > > > > + A bug in dump has been found where it can incorrectly dump > > > filesystems > > > > + with more than 512k inodes and produce corrupted dump images. > > > r334968 > > > > + closes the door by not dumping filesystems with more than 512k > > > inodes. > > > > + While older dumps may 'work' the image they produce may or may > not > > > be > > > > + readable depending on many factors. > > > > + > > > > > > Does it make since to put a temporary warning in newfs to warn users > > > of the "may bot be able to dump this fs" issue? > > > > > > > It does. > > > > However, there may have been an error in assessment, which I'm working > > through now. If so, there will be a revert. > > Ok, I am wondering some about this as I have: > Filesystem 1024-blocks Used Avail Capacity iused > ifree %iused Mounted on > /dev/ada0s2h 473659989 417657089 18110101 96% 918794 > 47949908 2% /mnt > > And have had that file system for at least a decade, > and it gets dump | restore on a fairly regular basis. Yea. Are you in a good position to test a fix for the core dump db@ was seeing? A dump /restore (though the restore should be to a second fs to test) There's two things my fix does: (1) backs out the mistaken limit check and (2) doesn't walk through a list that's guaranteed to be bogus and fall off the end. Warner