From owner-cvs-src@FreeBSD.ORG Fri Feb 15 13:31:36 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 062CB16A420; Fri, 15 Feb 2008 13:31:36 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D14DE13C45A; Fri, 15 Feb 2008 13:31:35 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m1FDVZKf061861; Fri, 15 Feb 2008 13:31:35 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m1FDVZje061860; Fri, 15 Feb 2008 13:31:35 GMT (envelope-from rwatson) Message-Id: <200802151331.m1FDVZje061860@repoman.freebsd.org> From: Robert Watson Date: Fri, 15 Feb 2008 13:31:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/coda coda_psdev.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2008 13:31:36 -0000 rwatson 2008-02-15 13:31:35 UTC FreeBSD src repository Modified files: sys/fs/coda coda_psdev.c Log: The possibly interruptible msleep in coda_call() means well, but is fundamentally fairly confused about how signals work and when it is appropriate for upcalls to be interrupted. In particular, we should be exempting certain upcalls from interruption, we should not always eventually time out sleeping on a upcall, and we should not be interrupting the sleep for certain signals that we currently are (including SIGINFO). This code needs to be reworked in the style of NFS interruptible mounts. MFC after: 1 month Revision Changes Path 1.47 +1 -1 src/sys/fs/coda/coda_psdev.c