Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Feb 2024 15:35:38 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 277194] shells/elvish: Update build flags for enhancing version information.
Message-ID:  <bug-277194-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277194

            Bug ID: 277194
           Summary: shells/elvish: Update build flags for enhancing
                    version information.
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: xiaqqaix@gmail.com
                CC: vendion@gmail.com
                CC: vendion@gmail.com
             Flags: maintainer-feedback?(vendion@gmail.com)

The instructions for how to enhance Elvish's version information has change=
d.
See https://github.com/elves/elvish/blob/master/PACKAGING.md and
https://pkg.go.dev/src.elv.sh@master/pkg/buildinfo for the latest instructi=
on.

Ideally the package revision should also be set, but I'm not sure how to do
that, so I'm leaving that out for now.

Elvish's Go package name has also changed to src.elv.sh from
github.com/elves/elvish, but since this doesn't seem to impact the usabilit=
y of
the port I'm also keeping that unchanged for now. Feel free to update that =
too.

diff --git a/shells/elvish/Makefile b/shells/elvish/Makefile
index 5ab1f4d25033..0fbf9b722e62 100644
--- a/shells/elvish/Makefile
+++ b/shells/elvish/Makefile
@@ -27,7 +27,7 @@ GH_TUPLE=3D     \

 GO_PKGNAME=3D    github.com/${GH_ACCOUNT}/${PORTNAME}
 GO_TARGET=3D     ./cmd/elvish
-GO_BUILDFLAGS=3D -ldflags=3D"-s -w -X
src.elv.sh/pkg/buildinfo.Version=3D${DISTVERSIONPREFIX}${DISTVERSION} -X
src.elv.sh/pkg/buildinfo.Reproducible=3Dtrue" \
+GO_BUILDFLAGS=3D -ldflags=3D"-s -w -X
src.elv.sh/pkg/buildinfo.BuildVariant=3Dfreebsd" \
                -buildmode=3Dpie
 GO_TESTFLAGS=3D  -race
 CGO_ENABLED=3D   0

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-277194-7788>