From owner-cvs-src@FreeBSD.ORG  Fri Mar  9 21:04:50 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id AE27F16A405;
	Fri,  9 Mar 2007 21:04:50 +0000 (UTC)
	(envelope-from julian@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 8710F13C4A3;
	Fri,  9 Mar 2007 21:04:50 +0000 (UTC)
	(envelope-from julian@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l29L4oDx046070;
	Fri, 9 Mar 2007 21:04:50 GMT
	(envelope-from julian@repoman.freebsd.org)
Received: (from julian@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l29L4ogw046069;
	Fri, 9 Mar 2007 21:04:50 GMT (envelope-from julian)
Message-Id: <200703092104.l29L4ogw046069@repoman.freebsd.org>
From: Julian Elischer <julian@FreeBSD.org>
Date: Fri, 9 Mar 2007 21:04:50 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/netgraph ng_base.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Mar 2007 21:04:50 -0000

julian      2007-03-09 21:04:50 UTC

  FreeBSD src repository

  Modified files:
    sys/netgraph         ng_base.c 
  Log:
  ng_apply_item should be void. It is called from the interrupt source or
  from whoever has dequeued the item from the queue. Generally they have
  no interest in the result, and even if it is called by the queuer, it
  should still pretend that it was queued. The queuer should be assuming
  that the call was queued and giving them the false confidence that they
  are getting status leads to hard to find bugs.
  
  Make it a void and remove all the code that tried to return status through it.
  
  Revision  Changes    Path
  1.127     +85 -14    src/sys/netgraph/ng_base.c