From owner-cvs-src@FreeBSD.ORG Wed Apr 20 08:37:54 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47F3C16A4CE; Wed, 20 Apr 2005 08:37:54 +0000 (GMT) Received: from cheer.mahoroba.org (gw4.mahoroba.org [218.45.22.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id E339443D2D; Wed, 20 Apr 2005 08:37:47 +0000 (GMT) (envelope-from ume@mahoroba.org) Received: from localhost (IDENT:+RAXtVqp9LZJjuwT/UZjnzbYiP+CzXIps51anSrqsJ9KZVL7a7dmQswhMZsdKqzJ@localhost [IPv6:::1]) (user=ume mech=CRAM-MD5 bits=0)j3K8bR0d009472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Apr 2005 17:37:28 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Wed, 20 Apr 2005 17:37:27 +0900 Message-ID: From: Hajimu UMEMOTO To: Garrett Wollman In-Reply-To: <16997.30227.769989.36407@khavrinen.csail.mit.edu> References: <16997.30227.769989.36407@khavrinen.csail.mit.edu> User-Agent: xcite1.38> Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/21.3 (i386--freebsd) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 4.11-RELEASE X-PGP-Key: http://www.imasy.or.jp/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE Organization: Internet Mutual Aid Society, YOKOHAMA MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeded SMTP AUTH authentication, not delayed by milter-greylist-2.0b5 (cheer.mahoroba.org [IPv6:::1]); Wed, 20 Apr 2005 17:37:28 +0900 (JST) X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-5.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, SUBJ_HAS_SPACES autolearn=ham version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on cheer.mahoroba.org cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/net getproto.c getprotoent.c getprotoname.c netdb_private.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2005 08:37:54 -0000 Hi, >>>>> On Tue, 19 Apr 2005 17:20:19 -0400 >>>>> Garrett Wollman said: wollman> If they are generally useful they should be globally visible, with the wollman> standard FreeBSD namespace protections. (In this case, this probably wollman> means that the __ versions stay as they are, and non-__ versions can wollman> be defined using aliases in a separate compilation unit.) I'm not sure they are really useful. I think they are preffered to use for thread applications. However, our get{serv,proto}*() is now thread-safe. So, we don't need to use get{serv,proto}*_r() to have just thread-safeness. Indeed, I started this work to call getservby*_r() from getaddrinfo() and getnameinfo(). But, after all, I didn't modify getaddrinfo() and getnameinfo() to call getservby*_r() directly. Further, getserv*_r() takes struct servent_data for its argument. So, once we decide to expose them, we will need to pay attention to an ABI compatibility in the future. So, we should be careful, IMHO. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/