From owner-freebsd-current Sat Jan 10 22:54:59 1998 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id WAA25883 for current-outgoing; Sat, 10 Jan 1998 22:54:59 -0800 (PST) (envelope-from owner-freebsd-current) Received: from lsd.relcom.eu.net (ache@lsd.relcom.eu.net [193.124.23.23]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id WAA25672 for ; Sat, 10 Jan 1998 22:53:21 -0800 (PST) (envelope-from ache@lsd.relcom.eu.net) Received: (from ache@localhost) by lsd.relcom.eu.net (8.8.8/8.8.8) id JAA11118; Sun, 11 Jan 1998 09:52:35 +0300 (MSK) (envelope-from ache) Date: Sun, 11 Jan 1998 09:52:33 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= X-Sender: ache@lsd.relcom.eu.net To: Peter Wemm cc: Joerg Wunsch , Mike Smith , FreeBSD-current Subject: Re: CVS DIFF fix for review (-L added) In-Reply-To: <199801110348.LAA21317@spinner.netplex.com.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, 11 Jan 1998, Peter Wemm wrote: > One of the patches you posted had the wrong number of arguments to > run_setup. You added two %s to the formats, but only added one extra > argument. As I see latest 'simplified' patch (which is CC'ed to info-cvs) do it correctly, just check. > Remember, this section of code is completely different in the current CVS, > as it calls an internal diff library rather than fork/exec/run-rcsdiff. > > peter@spinner[10:56am]~src-155> cvs --version > Concurrent Versions System (CVS) 1.9.23 (client/server) So why I contact info-cvs here according to your suggestion. Are they already fix diff problem in new version or similar workaround is needed? BTW, do you still against applying the fix into -current and -stable cvs (which 'cvs diff' remains broken)? -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/