Date: Fri, 09 Mar 2001 22:24:35 +0000 From: Brian Somers <brian@Awfulhak.org> To: Warner Losh <imp@harmony.village.org> Cc: Brian Somers <brian@Awfulhak.org>, freebsd-audit@FreeBSD.ORG, eivind@FreeBSD.ORG, brian@Awfulhak.org Subject: Re: libutil/MAXHOSTNAMELEN changes - plus a buffer overrun fix Message-ID: <200103092224.f29MOZu05704@hak.lan.Awfulhak.org> In-Reply-To: Message from Warner Losh <imp@harmony.village.org> of "Fri, 09 Mar 2001 15:10:18 MST." <200103092210.f29MAII10967@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[.....] }
> : > : + strncpy(host, buf, hsize);
> : >
> : > Should likely use strlcpy.
> :
> : The returned string (host) is not meant to be terminated if the host
> : fits exactly - eg, realhostname(ut.ut_host, UT_HOSTSIZE, ...).
>
> Then we should terminate it. That's a lame interface.
It's a practical interface. It's also a public interface :*)
> Warner
--
Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org>
<http://www.Awfulhak.org>; <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103092224.f29MOZu05704>