From owner-cvs-src@FreeBSD.ORG Sat Feb 3 00:27:44 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9CE7D16A403; Sat, 3 Feb 2007 00:27:44 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from alnrmhc12.comcast.net (alnrmhc12.comcast.net [204.127.225.92]) by mx1.freebsd.org (Postfix) with ESMTP id 541EB13C428; Sat, 3 Feb 2007 00:27:43 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from c-66-31-35-94.hsd1.ma.comcast.net ([66.31.35.94]) by comcast.net (alnrmhc12) with ESMTP id <20070203002743b1200k73dre>; Sat, 3 Feb 2007 00:27:43 +0000 Received: from c-66-31-35-94.hsd1.ma.comcast.net (localhost.crodrigues.org [127.0.0.1]) by c-66-31-35-94.hsd1.ma.comcast.net (8.13.8/8.13.8) with ESMTP id l130PiY1001608; Fri, 2 Feb 2007 19:25:51 -0500 (EST) (envelope-from rodrigc@c-66-31-35-94.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-66-31-35-94.hsd1.ma.comcast.net (8.13.8/8.13.8/Submit) id l130PiRh001593; Fri, 2 Feb 2007 19:25:44 -0500 (EST) (envelope-from rodrigc) Date: Fri, 2 Feb 2007 19:25:19 -0500 From: Craig Rodrigues To: Pawel Jakub Dawidek Message-ID: <20070203002519.GA1517@crodrigues.org> References: <200702022358.l12NwAlV049192@repoman.freebsd.org> <20070202235942.GC25236@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070202235942.GC25236@garage.freebsd.pl> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/mount Makefile mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Feb 2007 00:27:44 -0000 On Sat, Feb 03, 2007 at 12:59:43AM +0100, Pawel Jakub Dawidek wrote: > Should we also restart mountd(8) on successful umount(8)? Your fix to mount(8) is a good one, since the existing behavior of mount(8) is to SIGHUP mountd, based on the pid in /var/run/mountd.pid. I don't like how these sneaky behaviors with non-obvious side-effects sneak into existing utilities like mount(8).....but that's what we have today. A sneaky side effect of the existing behavior, is that when you SIGHUP mountd, it deletes all existing NFS exports, re-reads /etc/exports, and then re-creates all the NFS exports. Some people find this very annoying, especially when you are already using an NFS export ( http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/9619 ). I am looking at some patches from Andrey Simonenko which fix this problem, but they are quite intrusive changes to userland and kernel, so it is slow going on my part. So for now, I would recommend leaving umount alone, to avoid adding new side effects, even though based on existing behavior, it seems logical to add it. However, if this behavior is necessary for ZFS, then I won't oppose modifying umount to SIGHUP mountd. :) It seems a lot of cruft has accumulated in a simple utility like mount(8) over the years! -- Craig Rodrigues rodrigc@crodrigues.org