From nobody Thu Jul 9 17:49:34 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gx2XZ5j04z6kZst for ; Thu, 09 Jul 2026 17:49:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gx2XZ38p0z3h9F for ; Thu, 09 Jul 2026 17:49:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783619374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XSvZXzkMaGQYv0J/71yP2t2c2JQhM8oNqAUpCKIDGWA=; b=yLr7HQxc2aW6V5kjpH94AvgXgimcmltGW1BogZVmH5kObCawAXuFqv1ZQWYasRthpfLLI8 dqUic0X8fakGSxMcxTGFxcfCGUg3JV0DFzXA0ukJRWJcxz4mS2ijciYFlCdZAFSC80A+9x f1JW/U658onZhDxt+6jT931XlD6Us29QhJUHuep5CJ33CQT1zm/i0qjX3AjjiWhLLtRPW3 Ky5G7nqOzqR10fmAIlojSSrLqt7uGUHYv04+DKR2zwfpDXuZeZ9TuQh25MI2Kv6ls7r+Gi W/yivsKwDAO0PfbwgpgyWUMbSksMyekFV6OGTRQUvqGH9+RX2LRIqEZ+5h0zxA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783619374; a=rsa-sha256; cv=none; b=CwpaYfwpCBMWngtKTtAUd0wrbTNbKSD53MOpXBb5Q+LCfOmV/JQt/gQLZ7LRm15fejoi8J E/LfEfrtyPc0yxuYJRi3dWZq2BNKLhzWdWkP3UWC5+yGypT/LIBsGg4fUNbV3sIR3cDX0o k37UUvQd7zS28FlNvdF54L/1IMlma+zXEFr8pQ8pOCxx+MBRBH92tCl+KN6NME/4Ob6wGA d5wdeB1ktZAMUsYtrImNv7dtN1UnpRHTrRuPKtxyjYVDQhz0ayAxqHGaD5qKOm94JBXlhx resJnUIxlenofKYkpZz5s3mI0e7B0SAPfVguf76I0E7S1Ol9iFFN50/x2bqnrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783619374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XSvZXzkMaGQYv0J/71yP2t2c2JQhM8oNqAUpCKIDGWA=; b=xsjJlwB4Qu5Qby/A/yc+6EugZr67WEuMqEbrXUEy+KlMNdFMW8mZffq14mGESHj5wb5nfA O3K58xMP0ZpTR6e35Zz4ndid0InWshaKy+iRoVLwgwo0QoilbAMjQd0xYPTpAbuh9ABqoV T9HuYKi0ToFftNqPSvntNBJ1wf380l5Rmlrr736emvQTCUKI/pq6Vn+lE1mGXEZeynKXY+ rC+P6vB/f2MBEAL1jtulpGmZnyxqadLgELyE2IdYDlal9JtV/iLuT6yKXiPCSsU1R669uq uZvHHYyME8R7iHfumN+x8g9yHKQ3BOi1j4DEdRd3H2B37oj9Q8J3ZZiHgmvgdQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gx2XZ1MRdz3mx for ; Thu, 09 Jul 2026 17:49:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4043f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 09 Jul 2026 17:49:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mitchell Horne Subject: git: b17f8fdcc51b - stable/15 - raspberry_virtgpio: fix OF_hasprop() usage List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b17f8fdcc51b5f15b2a5bb13b524e479e5632f00 Auto-Submitted: auto-generated Date: Thu, 09 Jul 2026 17:49:34 +0000 Message-Id: <6a4fdf2e.4043f.6ca2a4ac@gitrepo.freebsd.org> The branch stable/15 has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=b17f8fdcc51b5f15b2a5bb13b524e479e5632f00 commit b17f8fdcc51b5f15b2a5bb13b524e479e5632f00 Author: Mitchell Horne AuthorDate: 2026-04-16 16:05:25 +0000 Commit: Mitchell Horne CommitDate: 2026-07-09 17:48:52 +0000 raspberry_virtgpio: fix OF_hasprop() usage The function returns a bool. This driver was merged recently (by me) and I missed this instance. While here, adjust the ofw_bus_status_okay() call similarly. This function still returns an int, but this usage is more widely used in our drivers. No functional change intended. MFC after: 3 days Sponsored by: The FreeBSD Foundation Fixes: b60cd486a652 ("ofw: bool-ify OF_hasprop()") (cherry picked from commit ce6b4973ba8c6503d3b6dc12d9e6b42ce274d912) --- sys/arm/broadcom/bcm2835/raspberrypi_virtgpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/arm/broadcom/bcm2835/raspberrypi_virtgpio.c b/sys/arm/broadcom/bcm2835/raspberrypi_virtgpio.c index 64ce6fda6306..797896a7f22b 100644 --- a/sys/arm/broadcom/bcm2835/raspberrypi_virtgpio.c +++ b/sys/arm/broadcom/bcm2835/raspberrypi_virtgpio.c @@ -206,14 +206,14 @@ rpi_virt_gpio_probe(device_t dev) union msg_gpiovirtbuf cfg; int rv; - if (ofw_bus_status_okay(dev) == 0) + if (!ofw_bus_status_okay(dev)) return (ENXIO); if (ofw_bus_search_compatible(dev, compat_data)->ocd_data == 0) return (ENXIO); gpio = ofw_bus_get_node(dev); - if (OF_hasprop(gpio, "gpio-controller") == 0) + if (!OF_hasprop(gpio, "gpio-controller")) return (ENXIO); /* Check whether the firmware is ready. */