From owner-freebsd-current@freebsd.org Sat Oct 17 11:12:03 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC252A179F7 for ; Sat, 17 Oct 2015 11:12:03 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A601B182; Sat, 17 Oct 2015 11:12:03 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::3d8f:5ec8:9c1e:840c] (unknown [IPv6:2001:7b8:3a7:0:3d8f:5ec8:9c1e:840c]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 531AC25491; Sat, 17 Oct 2015 13:11:54 +0200 (CEST) Subject: Re: FreeBSD_HEAD_amd64_gcc4.9 - Build #673 - Failure Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3094\)) Content-Type: multipart/signed; boundary="Apple-Mail=_03F19085-9B0A-4EBD-A7F1-2FE1A1C268A6"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.6b2 From: Dimitry Andric In-Reply-To: <78883694-7B54-4AC3-9B5B-D715D5DA1F88@gmail.com> Date: Sat, 17 Oct 2015 13:11:47 +0200 Cc: Bryan Drewery , jenkins-admin@FreeBSD.org, freebsd-current@FreeBSD.org Message-Id: References: <1743862498.27.1445058611319.JavaMail.jenkins@jenkins-9.freebsd.org> <5621D9F1.9080707@FreeBSD.org> <5621DDB1.8020807@FreeBSD.org> <31F4FEC4-B677-4EA1-BD67-F2DC458A99E4@gmail.com> <2B9A4B89-6D0D-4549-B249-FB30A8117DDF@gmail.com> <78883694-7B54-4AC3-9B5B-D715D5DA1F88@gmail.com> To: Garrett Cooper X-Mailer: Apple Mail (2.3094) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2015 11:12:04 -0000 --Apple-Mail=_03F19085-9B0A-4EBD-A7F1-2FE1A1C268A6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 17 Oct 2015, at 09:09, NGie Cooper wrote: ... > Also, this logic looks troublesome: >=20 > 42 .if empty(TOOLSDIR) || !exists(${TOOLSDIR}/usr/bin/clang-tblgen) > 43 .if ${MACHINE} =3D=3D "host" && defined(BOOTSTRAPPING_TOOLS) > 44 .if !empty(LEGACY_TOOLS) && exists(${LEGACY_TOOLS}/usr/bin/tblgen) > 45 TOOLSDIR=3D ${LEGACY_TOOLS} > 46 .endif > 47 .endif > 48 .if ${MK_STAGING} =3D=3D "yes" && = exists(${STAGE_HOST_OBJTOP:Uno}/usr/bin/tblgen) > 49 TOOLSDIR=3D ${STAGE_HOST_OBJTOP} > 50 .endif > 51 .if exists(${LEGACY_TOOLS:Uno}/usr/bin/tblgen) > 52 TOOLSDIR=3D ${LEGACY_TOOLS} > 53 .endif > 54 .endif > 55 TOOLSDIR?=3D > 56 .if !empty(TOOLSDIR) && exists(${TOOLSDIR}/usr/bin/clang-tblgen) > 57 TBLGEN=3D ${TOOLSDIR}/usr/bin/tblgen > 58 CLANG_TBLGEN=3D ${TOOLSDIR}/usr/bin/clang-tblgen > 59 .endif > 60 TBLGEN?=3D tblgen > 61 CLANG_TBLGEN?=3D clang-tblgen >=20 > This kind of complexity matched something that I simplified at $work = due to build races=85 This stuff was added by sjg as part of his meta-mode commit frenzy in r284345, but I never really agreed to it, nor do I understand what its function is. It was just splattered all over the tree. Can we just remove it for now, and put it back when it works, and is actually used for something? :-) -Dimitry --Apple-Mail=_03F19085-9B0A-4EBD-A7F1-2FE1A1C268A6 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.28 iEYEARECAAYFAlYiLPkACgkQsF6jCi4glqO8IQCeKYF7C2qo0ZZN7EWFlHGIk6oT xv0An1PySRgkaiArhsDQHb23yaWMgZ9d =0VX/ -----END PGP SIGNATURE----- --Apple-Mail=_03F19085-9B0A-4EBD-A7F1-2FE1A1C268A6--