From nobody Sat Apr 29 18:49:28 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q7z6k4KWgz486YW; Sat, 29 Apr 2023 18:49:50 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q7z6k3XpTz3MD4; Sat, 29 Apr 2023 18:49:50 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682794190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TqHO9CxKT8y/vXageY768331LJPXD85X1fhg+BXvJng=; b=ykhNFCBnLLa8OHR18+pmyUPis2GU4oJk24Q9clg5kiPW7GvhYQT1XPlpjLKjIIogzgKEv+ FoCqVdM/WATTUNu8zgjg0DcXbnh5UqT6BdjZI33Syhw/KZLQ2aujI1UZYfQay9iwUzhpCp /BXgAkm2/JCxPYSdAzqu1sTVBePndeBSPapm9cp4eiRFCyMbkJ6cURlgYkYQFL3ThijbuH ZCBWizgotaU6sgVH+LgYyDBUSpk4VTJony/B2RgaUWT5ACOOZRxW5BtikL1mt+FjIH/rJU 9yLGmf9GSP8RQGoDvwb/n5nVtrAcssWAcN1I3FZVEmnHFVWGUbn/iFC0/4Z0cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682794190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TqHO9CxKT8y/vXageY768331LJPXD85X1fhg+BXvJng=; b=yr8ke5qEZCc05oa7w8GAnw+9W4vC2RlyV9dzI5Ld+vVHhSPMBOvUfWTKyJrOUz6VwNkSor L11Qprn3KosYcF329iv+5eqoDDPWsbXOMA/osOnm2stm1wrJYbjc9Cyi9qKVCrWUGWPo6X djWlkKZgOgnWR5jXsyzHVS62TtfN3xcpNywqSl7cOotZC/7Q/XcV1L90WNhbjcC7uptaiK WqUQdeVcmbGbwt+WFzQ5Y9d6eIqFhiw6m7+II+FCdT6MEYs/hn8gy0a4cJKVV8WZeJw9lr 23WlTB5UV9+BUrTJQJMU7yfyt6aDL/GkLecZGE63YPOpF3uv074WXXi7C9/vqw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682794190; a=rsa-sha256; cv=none; b=PFvYZUYzouLXCuAdOXjzRG3KqAhHkv/I2Ihwq3MFz7UmvV52jIjR+nkEK6okZPWnALUBoo JiGGjqYrDGb1U0xfOTwzAlJWzFtm7QcEmDcmTr2K7cuhcRYU/PjBcLEzvU2YmV2pHr7AUS E/Oz5rj34RDwzO/IvLb0e1FVSXj+sDdOkAqW2IJxq/RmNxDe/pSiEP4UaUOS4gpO/C6tjV v6WcG6w4z7z6aYNbKWMegAPSxmxpyMLWaTVoFtVa3oj/K5T+wKztWaJagDnd1MuHL//h0h vrkqNy2eFi+sKV3Gzd6MHZzfLcD5BzR5EYvBdW8i2DjOyzIPOLdwUlNt1cGZ5w== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Q7z6k1gJRzvn4; Sat, 29 Apr 2023 18:49:50 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 78CC96C619; Sat, 29 Apr 2023 20:49:47 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_0A7B0216-61FD-41C1-8D04-7A255634871E"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Commits to the stable branches of the FreeBSD src repository <dev-commits-src-branches.freebsd.org> List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: <mailto:dev-commits-src-branches+help@freebsd.org> List-Post: <mailto:dev-commits-src-branches@freebsd.org> List-Subscribe: <mailto:dev-commits-src-branches+subscribe@freebsd.org> List-Unsubscribe: <mailto:dev-commits-src-branches+unsubscribe@freebsd.org> Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: git: 060699e91369 - stable/13 - Merge llvm-project release/15.x llvmorg-15.0.7-0-g8dfdcc7b7bf6 From: Dimitry Andric <dim@FreeBSD.org> In-Reply-To: <ZE1jEcA7iL3QrbOP@corona> Date: Sat, 29 Apr 2023 20:49:28 +0200 Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Message-Id: <76DD2CB9-986B-4349-8F46-3B7BF63EB315@FreeBSD.org> References: <202304092135.339LZMeJ081640@gitrepo.freebsd.org> <ZE1jEcA7iL3QrbOP@corona> To: "Jason A. Harmening" <jah@FreeBSD.org> X-Mailer: Apple Mail (2.3731.500.231) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_0A7B0216-61FD-41C1-8D04-7A255634871E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 29 Apr 2023, at 20:33, Jason A. Harmening <jah@FreeBSD.org> wrote: >=20 > On Sun, Apr 09, 2023 at 09:35:22PM +0000, Dimitry Andric wrote: >> The branch stable/13 has been updated by dim: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D060699e9136975d51d3f726b9785bdba= c9a62ba6 >>=20 >> commit 060699e9136975d51d3f726b9785bdbac9a62ba6 >> Author: Dimitry Andric <dim@FreeBSD.org> >> AuthorDate: 2023-01-14 16:33:24 +0000 >> Commit: Dimitry Andric <dim@FreeBSD.org> >> CommitDate: 2023-04-09 14:54:52 +0000 >>=20 >> Merge llvm-project release/15.x llvmorg-15.0.7-0-g8dfdcc7b7bf6 >>=20 >> This updates llvm, clang, compiler-rt, libc++, libunwind, lld, = lldb and >> openmp to llvmorg-15.0.7-0-g8dfdcc7b7bf6. >>=20 >> PR: 265425 >> MFC after: 2 weeks >=20 > This MFC of llvm15 appears to have completely broken the Intel IOMMU > driver on my stable/13 machine. After this series of commits, any > downstream DMA seems to produce an IOMMU translation fault, which > renders the machine completely unusable: no nvme boot disk, no usb > keyboard, etc. >=20 > The faults I see look something like this: >=20 > DMAR4: ahci0: pci0:17:5 sid 8d fault acc 0 adt 0x0 reason 0x3 addr = 26000 >=20 > It's a bit surprising to see a toolchain upgrade produce breakage like > this, but that's what git bisect clearly tells me. I wonder if some = of > the IOMMU control structures might be defined as C bitfields and the = new > compiler is emitting them differently? Also, was any breakage like = this > observed when -current was upgraded to llvm15 several months ago? I haven't heard anything about such breakage, no. > More generally, this is the second time in as many months I've had to > deal with IOMMU breakage on -stable. I can't imagine I'm the only > person who sees value in running with DMA remapping enabled; do we = need > a dedicated DMAR-enabled machine in the cluster to smoke-test changes > like this? More generally, should we avoid MFCing high-risk changes > like this? Since there were very few bug reports, it was not deemed high risk. In any case, it would be good to get the bottom of what is causing the problem, so is there any way you can isolate which code seems to be going "bad"? For example, if this problem affects code in sys/dev/iommu, is there some way you can compile that part with -O1, or with an older version of clang (from ports), to see if the problem goes away? -Dimitry --Apple-Mail=_0A7B0216-61FD-41C1-8D04-7A255634871E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCZE1muAAKCRCwXqMKLiCW oy00AKCwpvrYumXL236UwYfGxhdFE9qgigCg4vgGpZCot6DuSFY4kKfXLnnt22U= =Yq+u -----END PGP SIGNATURE----- --Apple-Mail=_0A7B0216-61FD-41C1-8D04-7A255634871E--