From owner-cvs-src@FreeBSD.ORG Sun Jan 29 06:17:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9D0016A429; Sun, 29 Jan 2006 06:17:31 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9624843D45; Sun, 29 Jan 2006 06:17:31 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.240] (ppp-71-139-114-10.dsl.snfc21.pacbell.net [71.139.114.10]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id k0T6HUD8024852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 28 Jan 2006 22:17:30 -0800 Message-ID: <43DC5E0B.40003@root.org> Date: Sat, 28 Jan 2006 22:17:47 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kris Kennaway References: <200601290551.k0T5pwEC028440@repoman.freebsd.org> <20060129060654.GA47495@xor.obsecurity.org> <20060129061300.GA47596@xor.obsecurity.org> In-Reply-To: <20060129061300.GA47596@xor.obsecurity.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Nate Lawson , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/defaults rc.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jan 2006 06:17:32 -0000 Kris Kennaway wrote: > On Sun, Jan 29, 2006 at 01:06:54AM -0500, Kris Kennaway wrote: > >>On Sun, Jan 29, 2006 at 05:51:58AM +0000, Nate Lawson wrote: >> >>>njl 2006-01-29 05:51:58 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> etc/defaults rc.conf >>> Log: >>> Enable the lowest Cx state by default. This will save power and we have >>> had enough testing of acpi_cpu to know this is stable now. >> >>On my desktop system (running RELENG_6 though), setting >>hw.acpi.cpu.cx_lowest=C0 causes atrocious performance. Is it broken >>in 6.x? > > C2, sorry. Ah, C0 should be disallowed already I thought (try it). As for C2, I MFCd a patch to acpi_cpu.c in November that should prevent this (1.57.2.1). Do you get a printf on console? Commit msg: If we're trying to use C2/3 and reads from the register are returning immediately, back off to the next higher Cx sleep state. Some machines with a Via chipset report a valid C3 but a register read doesn't actually halt the CPU. This would cause the machine to appear unresponsive as it repeatedly called cpu_idle() which immediately returned. Causing interrupts (i.e. by pressing the power button) would cause the system to make forward progress, showing that it wasn't actually hung. Also, enable interrupts a little earlier. We don't need them disabled to calculate the delta time for the read. -- Nate