From nobody Mon Apr 28 16:17:45 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZmTBZ60Mrz5vXkY; Mon, 28 Apr 2025 16:17:58 +0000 (UTC) (envelope-from jlduran@gmail.com) Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZmTBZ1xRFz3Q8f; Mon, 28 Apr 2025 16:17:58 +0000 (UTC) (envelope-from jlduran@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yb1-xb35.google.com with SMTP id 3f1490d57ef6-e6b78b80393so657761276.1; Mon, 28 Apr 2025 09:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745857077; x=1746461877; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=mQMqBRtI7rqDjwPBsLPLJ8Bk5dbYF/HkTBiMbcbG4GA=; b=hQPVmBDQT2YiUt3SlSKycChHstSdk7KDVbc0qWDTlFV/Q5zIv5xkrVvwbIUGKOBCy1 s69w93ZEHBhPcYNJl9oMfSUuOwomiBfHTQ9+uvbXOHVAHglgBw8we/1lpY//Hc2EfQpH 2yM0iKZvZI+KaRfnZDWLfUuA4dvlwvjPJrF9Tzjr1Ke42QkP0XDbG6BHK9lsr/teMrP7 FCuVzAPbE2+DUOih0TZsQrusbUK0XbkPg67pFbRTi06NeRlMgEbcUkxeEAx/+c+J7/D1 YJRMnx8lb7YlwsNo/2+5DvqUgIyBkbFijr3j1gwAA0+7hSv5wmhwLJA53CGSSTY2v61S iRfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745857077; x=1746461877; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mQMqBRtI7rqDjwPBsLPLJ8Bk5dbYF/HkTBiMbcbG4GA=; b=l5rPeu6KZLVSEFdxuxWWYmspwfhv2NC43Rz6M3Sfn+nK2jodBujTAl9j4gGRaxn9Cq ofVzEu7Q1kvCIb3qYW8hctYMJJDzCsoL6UKN0LWH1y0+NkUWJCCcRM2X5tVYuzymOP3i 1PmUwSr+6l3qiL1sgJEX8yb9q5vcTn+Wqf5ZTNbl+NNzIrXo0QpFil5NozxxQjYnhWnr rafshjg+/O7aztrdOoNoI//JBQS2DKYELPZVqXopNQz46QGrzXCuSQoYqOjEZLMdozcM Q06BZXkj9yJro5hfrvuV5jBri8gPkgrXW8+2tzlKLU5hAlV+kx1fgEyGVFc65ZBDOEJ2 jCvA== X-Forwarded-Encrypted: i=1; AJvYcCUQiLr6JlXybg/et5fFoEZnOc/pEROIXn9GEqt26SejFJp4/PH2f01SZlYRe6SQv/GFJZ9/KihrkyIfmlM2msm+hbcatZg=@freebsd.org, AJvYcCUu7mkYF4TzsG3yJrPWSUJgEunMf4KRScPzL/PtKuuDNR6GphWofS42sj5OmzC33YZr+T0vYEerhx5KiyB5Ulo=@freebsd.org, AJvYcCWvlKbQNbtQXKbsa/6qVEZIBwNHVXkjot/1Wou/w4WULgrCqiyH4fR0lBTs+cuSfgT+FafiFQXxp8GcbwU8KIbuu5P2@freebsd.org X-Gm-Message-State: AOJu0YwJCxYAkb/nl8rxwZ2X63vD2G7kh31EHP263/9t/JWh8sXu3YWa D8+pCwhSsWtu8ik68gjMcAHBYfMbCewUp8KuRcIVkfX+XIXwUqadh0iZs311rq8EurTSTh2jOCG Wxp8AZccJG5C58qKjNhnlSnBfMmhrrxAjz0g= X-Gm-Gg: ASbGncsRazvmT/Xuon1lVi1UJzoEImoKUYB20OcJLQXDbZs5xMg56cwlFHstNjljV1z 39iKZH1cedYx6cg7I2GjTR4Ikc4FKJWKBPq7Fnj7snGgbwrnDoTWN5vodEVFRPU2yDCzB/CEp/m yiqVwiMxMzw7RPo0wzxLSEXMc= X-Google-Smtp-Source: AGHT+IFGmWM7l3MIpTD8mPwTeqmptD2/gnbugTw575l/KUXLP7521Rei49w5OBvFzc4Sm8axRR850cuqWybX1FzOT80= X-Received: by 2002:a05:6902:981:b0:e6d:e693:4109 with SMTP id 3f1490d57ef6-e7316495abcmr8017324276.0.1745857076827; Mon, 28 Apr 2025 09:17:56 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202504220207.53M27okn077850@gitrepo.freebsd.org> <5a261558-6c1f-4e29-a71b-fd3cb6bd1e70@FreeBSD.org> In-Reply-To: <5a261558-6c1f-4e29-a71b-fd3cb6bd1e70@FreeBSD.org> Reply-To: jlduran+freebsd@freebsd.org From: Jose Luis Duran Date: Mon, 28 Apr 2025 11:17:45 -0500 X-Gm-Features: ATxdqUHtHj-2hlTkkHsqNouIdK_HF8ClttMn9wTmyuANMCO0-jhPF4-BSQK88hE Message-ID: Subject: Re: git: a098111a28ed - main - secure: Add ssh-sk-client to all consumers of libssh To: John Baldwin Cc: Jessica Clarke , Shawn Webb , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[freebsd]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4ZmTBZ1xRFz3Q8f X-Spamd-Bar: ---- On Mon, Apr 28, 2025 at 10:45=E2=80=AFAM John Baldwin wro= te: > > On 4/24/25 18:56, Jessica Clarke wrote: > > On 24 Apr 2025, at 23:45, Shawn Webb wrote= : > >> On Tue, Apr 22, 2025 at 02:07:50AM +0000, John Baldwin wrote: > >>> The branch main has been updated by jhb: > >>> > >>> URL: https://cgit.FreeBSD.org/src/commit/?id=3Da098111a28ed59e1ab1101= ad09913f0235ebd28f > >>> > >>> commit a098111a28ed59e1ab1101ad09913f0235ebd28f > >>> Author: John Baldwin > >>> AuthorDate: 2025-04-22 02:05:28 +0000 > >>> Commit: John Baldwin > >>> CommitDate: 2025-04-22 02:05:28 +0000 > >>> > >>> secure: Add ssh-sk-client to all consumers of libssh > >>> > >>> These all failed to link with ld.bfd used by GCC due to > >>> Fssh_sshsk_sign being an unresolved symbol. > >>> > >>> Fixes: 65d8491719bb ("secure: Adapt Makefile to ssh-sk-c= lient everywhere") > >> > >> Hey John, > >> > >> I'm getting the following error from the RTLD when the rc scripts > >> start sshd: > >> > >> =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > >> ld-elf.so.1: /usr/lib/libprivatessh.so.5: Undefined symbol "Fssh_sshsk= _sign > >> =3D=3D=3D=3D END LOG =3D=3D=3D=3D > >> > >> This is on HardenedBSD 15-CURRENT/amd64. I'll try to reproduce next > >> week with vanilla FreeBSD, unless someone else beats me to it. > > This error seems to be that you've built the new libssh but have an old > sshd, etc. > > > I don=E2=80=99t understand how this is meant to work. sshsk_sign is use= d by > > sshkey.c, which is in libssh, so why are we putting the definition of > > sshsk_sign (namespaced) in each and every program? > > Yeah, it's not clear to me that the original commit is correct. It makes > libssh no longer be self-contained. I have created: https://reviews.freebsd.org/D50020 > -- > John Baldwin >