From owner-svn-src-projects@FreeBSD.ORG Sat Feb 9 17:34:49 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 0567E3C0; Sat, 9 Feb 2013 17:34:49 +0000 (UTC) (envelope-from cherry@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id EC9E467D; Sat, 9 Feb 2013 17:34:48 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r19HYmQT012279; Sat, 9 Feb 2013 17:34:48 GMT (envelope-from cherry@svn.freebsd.org) Received: (from cherry@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id r19HYmSC012278; Sat, 9 Feb 2013 17:34:48 GMT (envelope-from cherry@svn.freebsd.org) Message-Id: <201302091734.r19HYmSC012278@svn.freebsd.org> From: "Cherry G. Mathew" Date: Sat, 9 Feb 2013 17:34:48 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r246597 - projects/amd64_xen_pv/sys/amd64/xen X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Feb 2013 17:34:49 -0000 Author: cherry Date: Sat Feb 9 17:34:48 2013 New Revision: 246597 URL: http://svnweb.freebsd.org/changeset/base/246597 Log: Remove unnecessary sign extension (48bit upward) masking on va. This is relevant only for the pml4t offset calculation. Approved by: gibbs (implicit) Modified: projects/amd64_xen_pv/sys/amd64/xen/mmu_map.c Modified: projects/amd64_xen_pv/sys/amd64/xen/mmu_map.c ============================================================================== --- projects/amd64_xen_pv/sys/amd64/xen/mmu_map.c Sat Feb 9 17:32:00 2013 (r246596) +++ projects/amd64_xen_pv/sys/amd64/xen/mmu_map.c Sat Feb 9 17:34:48 2013 (r246597) @@ -71,20 +71,12 @@ pml4t_index(uintptr_t va) static int pdpt_index(uintptr_t va) { - /* amd64 sign extends 48th bit and upwards */ - const uint64_t SIGNMASK = (1UL << 48) - 1; - va &= SIGNMASK; /* Remove sign extension */ - return ((va & PML4MASK) >> PDPSHIFT); } static int pdt_index(uintptr_t va) { - /* amd64 sign extends 48th bit and upwards */ - const uint64_t SIGNMASK = (1UL << 48) - 1; - va &= SIGNMASK; /* Remove sign extension */ - return ((va & PDPMASK) >> PDRSHIFT); } @@ -92,10 +84,6 @@ pdt_index(uintptr_t va) static int pt_index(uintptr_t va) { - /* amd64 sign extends 48th bit and upwards */ - const uint64_t SIGNMASK = (1UL << 48) - 1; - va &= SIGNMASK; /* Remove sign extension */ - return ((va & PDRMASK) >> PAGE_SHIFT); } #endif