From owner-freebsd-acpi@FreeBSD.ORG Mon Jul 9 19:02:44 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BAA5B106566B; Mon, 9 Jul 2012 19:02:44 +0000 (UTC) (envelope-from robert.moore@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx1.freebsd.org (Postfix) with ESMTP id 9062B8FC12; Mon, 9 Jul 2012 19:02:44 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 09 Jul 2012 12:01:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="175167547" Received: from orsmsx603.amr.corp.intel.com ([10.22.226.49]) by fmsmga001.fm.intel.com with ESMTP; 09 Jul 2012 12:01:35 -0700 Received: from orsmsx104.amr.corp.intel.com (10.22.225.131) by orsmsx603.amr.corp.intel.com (10.22.226.49) with Microsoft SMTP Server (TLS) id 8.2.255.0; Mon, 9 Jul 2012 12:01:35 -0700 Received: from orsmsx101.amr.corp.intel.com ([169.254.8.125]) by ORSMSX104.amr.corp.intel.com ([169.254.3.118]) with mapi id 14.01.0355.002; Mon, 9 Jul 2012 12:01:35 -0700 From: "Moore, Robert" To: Ian Smith , Nate Lawson Thread-Topic: disabled CST_CNT write Thread-Index: AQHNXOm4Gnse3k84fEq/PZ8XFH+/dZcgDu6AgAGGFoD//7t88A== Date: Mon, 9 Jul 2012 19:01:34 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E346B0A852@ORSMSX101.amr.corp.intel.com> References: <4FF94EC4.1060109@FreeBSD.org> <023CA42F-C5FD-4F67-AD70-84DE68B3FBA8@root.org> <20120710014934.J42038@sola.nimnet.asn.au> In-Reply-To: <20120710014934.J42038@sola.nimnet.asn.au> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "freebsd-acpi@freebsd.org" , Andriy Gapon Subject: RE: disabled CST_CNT write X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 19:02:44 -0000 > This Thinkpad T23 with latest (Oct2006) BIOS & EC shows no FADT .. but > FACP has CST_CNT=3D0xf4. Is that relevant at all? An oddity of ACPI -- the FADT has the signature "FACP". > -----Original Message----- > From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- > acpi@freebsd.org] On Behalf Of Ian Smith > Sent: Monday, July 09, 2012 9:06 AM > To: Nate Lawson > Cc: freebsd-acpi@freebsd.org; Andriy Gapon > Subject: Re: disabled CST_CNT write >=20 > On Sun, 8 Jul 2012 09:49:57 -0700, Nate Lawson wrote: > > On Jul 8, 2012, at 2:11 AM, Andriy Gapon wrote: > > > > > acpi_cpu.c has a block of code to write CST_CNT to SMI_CMD, but > the block is > > under #ifdef notyet. It seems that the code was > added that many years ago and > > never enabled. > > > Now, judging from the reports I've seen on this mailing list, it > appears that > > _CST changes do happen and the driver seem to handle > them sufficiently well. > > > I think that a lot of modern platforms do not even provide CST_CNT > and assume > > that an OS is able to handle C-state change > notifications. > > > So, I guess that it should be safe to enable the code in question > now. > > > > > > Could anyone with a FreeBSD laptop and non-zero CST_CNT in FADT > > > please test this? >=20 > This Thinkpad T23 with latest (Oct2006) BIOS & EC shows no FADT .. but > FACP has CST_CNT=3D0xf4. Is that relevant at all? >=20 > > It was only under an #ifdef because at the time our CST > > implementation couldn't handle CST changes cleanly. I had added some > > support for it, but since it couldn't be tested, I wasn't sure how > > actual hardware would behave. > > > > I think it's fine to enable now. I think 2007-era Thinkpads were > some > of the first to add this feature. >=20 > T43? Maybe it's time I upgraded :) >=20 > cheers, Ian > _______________________________________________ > freebsd-acpi@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-acpi > To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org"