From owner-freebsd-hackers Thu Oct 23 11:15:24 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id LAA15796 for hackers-outgoing; Thu, 23 Oct 1997 11:15:24 -0700 (PDT) (envelope-from owner-freebsd-hackers) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id LAA15780 for ; Thu, 23 Oct 1997 11:15:14 -0700 (PDT) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id LAA21430; Thu, 23 Oct 1997 11:13:00 -0700 (PDT) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpd021424; Thu Oct 23 18:12:50 1997 Date: Thu, 23 Oct 1997 11:11:16 -0700 (PDT) From: Julian Elischer To: Mike Smith cc: Archie Cobbs , freebsd-hackers@FreeBSD.ORG Subject: Re: Broken device LKM in 2.2 In-Reply-To: <199710231448.AAA00606@word.smith.net.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk well it works with this change and doesn't even compile without it.. terry (who originaly wrote it) works here now, and blessed it.. and I can't see a problem.. how much do you need? I'm planning on committing it myself unless someone gets to it first. julian On Fri, 24 Oct 1997, Mike Smith wrote: > > > > I guess nobody makes device type LKM's in 2.2.. but sys/lkm.h is > > broken with respect to them. Here's a hack that fixes this. Perhaps > > the "name ## _module", which is different from the other module > > types, is there for some reason (?) > > IIRC it's there to avoid symbol conflicts with statically loaded > versions. Could be wrong of course; there's nothing in the CVS log. > > > Anyway, it's incompatible with the DISPATCH macro defined later in > > the file, and this fixes it... > > Has anyone looked at this? Should we buy it? > > mike > > >