Date: Sun, 24 Jun 2012 14:38:54 -0400 From: Robert Simmons <rsimmons0@gmail.com> To: "J. Hellenthal" <jhellenthal@dataix.net> Cc: ports@freebsd.org Subject: Re: security/openssh-portable line # 82 of rc.d/openssh generates DSA not ECDSA Message-ID: <CA%2BQLa9AvZcB4PA%2B=4F3Ue-HeOn40k50S89TS%2Bi8DFXcDWe2WzA@mail.gmail.com> In-Reply-To: <20120624182452.GB4715@DataIX.net> References: <20120624171753.GA15646@DataIX.net> <CA%2BQLa9Av=G98qc1jh00M6u2TBLsG0k0TLS2ujk1YnWTV9TyVFQ@mail.gmail.com> <20120624182452.GB4715@DataIX.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 24, 2012 at 2:24 PM, J. Hellenthal <jhellenthal@dataix.net> wro= te: > On Sun, Jun 24, 2012 at 01:46:20PM -0400, Robert Simmons wrote: >> On Sun, Jun 24, 2012 at 1:17 PM, J. Hellenthal <jhellenthal@dataix.net> = wrote: >> > >> > As stated in the subject >> > >> > if [ -f /usr/local/etc/ssh/ssh_host_ecdsa_key ]; then >> > =A0 =A0 =A0 =A0echo "You already have a Elliptic Curve DSA host key" \ >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"in /usr/local/etc/ssh/ssh_host_ecdsa_k= ey" >> > =A0 =A0 =A0 =A0echo "Skipping protocol version 2 Elliptic Curve DSA Ke= y Generation" >> > else >> > =A0 =A0 =A0 =A0/usr/local/bin/ssh-keygen -t dsa \ >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0-f /usr/local/etc/ssh/ssh_host_ecdsa_ke= y -N '' >> > fi >> > >> > >> > Specifically "/usr/local/bin/ssh-keygen -t dsa" needs to be changed to >> > "-t ecdsa" to be correct. Otherwise we are just reimplementing a DSA k= ey >> > in a different file. >> >> Good eye. =A0I'm in the process of updating that port to 6.0p1. =A0There >> are quite a lot of local patches that are part of the port. =A0At the >> moment I'm muddling through what they do and whether they can be >> removed or not. =A0I didn't even notice this problem. >> >> I've attached a pair of patches that correct this problem. =A0Open a PR >> about this, and you can attach these patches to it. =A0I'm not the >> maintainer nor do I have commit privileges, but if you open a PR, I'm >> sure someone will make the change. > > Should have also said the changes were already committed. I also want to see what can be pushed upstream. I understand that the OpenBSD/OpenSSH people are touchy about outside patches, but I think they should at least accept a patch to configure so that FreeBSD's native openpty() is detected properly.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BQLa9AvZcB4PA%2B=4F3Ue-HeOn40k50S89TS%2Bi8DFXcDWe2WzA>