Date: Sat, 2 Sep 2023 18:44:01 +0200 From: Christoph Moench-Tegeder <cmt@burggraben.net> To: Baptiste Daroussin <bapt@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8e3a5d951eb8 - main - devel/pkgconf: update to 2.0.2 Message-ID: <ZPNmUVF9XFelsH9R@elch.exwg.net> In-Reply-To: <202309011338.381DcplN040273@gitrepo.freebsd.org> References: <202309011338.381DcplN040273@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
## Baptiste Daroussin (bapt@FreeBSD.org):
This patch causes a regression:
> diff --git a/devel/pkgconf/files/patch-modversion-comparison b/devel/pkgconf/files/patch-modversion-comparison
> new file mode 100644
> index 000000000000..a8d4c26e6c0a
> --- /dev/null
> +++ b/devel/pkgconf/files/patch-modversion-comparison
> @@ -0,0 +1,13 @@
> +diff --git cli/main.c cli/main.c
> +index 25ff5ca..d75bbb7 100644
> +--- cli/main.c
> ++++ cli/main.c
> +@@ -306,7 +306,7 @@ apply_modversion(pkgconf_client_t *client, pkgconf_pkg_t *world, void *data, int
> + pkgconf_dependency_t *dep = world_iter->data;
> + pkgconf_pkg_t *pkg = dep->match;
> +
> +- if (strncmp(pkg->id, queue_node->package, strlen(pkg->id)))
> ++ if (strcmp(pkg->id, queue_node->package))
> + continue;
> +
> + if (pkg->version != NULL) {
Because:
from source 1.8.1
pkgconf-1.8.1$ ./pkgconf --modversion 'gtk+-2.0 >= 2.0.0'
2.24.33
and from source 2.0.2:
pkgconf-2.0.2$ ./pkgconf --modversion 'gtk+-2.0 >= 2.0.0'
2.24.33
but as installed (with patch):
tmp$ /usr/local/bin/pkgconf --modversion 'gtk+-2.0 >= 2.0.0'
tmp$
That's bad because perl's ExtUtils::PkgConfig (from
devel/p5-ExtUtils-PkgConfig p5-ExtUtils-PkgConfig-1.16) relies on the
old behaviour - and at least x11-toolkits/p5-Gtk2 now fails.
Regards,
Christoph
--
Spare Space
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZPNmUVF9XFelsH9R>