From owner-cvs-all@FreeBSD.ORG  Wed Nov 14 20:24:35 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5537416A469;
	Wed, 14 Nov 2007 20:24:35 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 040E113C478;
	Wed, 14 Nov 2007 20:24:34 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id lAEKNWmL022777;
	Wed, 14 Nov 2007 13:23:32 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Wed, 14 Nov 2007 13:23:32 -0700 (MST)
Message-Id: <20071114.132332.74728138.imp@bsdimp.com>
To: kris@FreeBSD.org
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <473AC77C.40903@FreeBSD.org>
References: <200711140543.lAE5ht3O020823@repoman.freebsd.org>
	<473AC77C.40903@FreeBSD.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, julian@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/bios apm.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Nov 2007 20:24:35 -0000

From: Kris Kennaway <kris@FreeBSD.org>
Subject: Re: cvs commit: src/sys/i386/bios apm.c
Date: Wed, 14 Nov 2007 11:01:32 +0100

> Julian Elischer wrote:
> > julian      2007-11-14 05:43:55 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/i386/bios        apm.c 
> >   Log:
> >   Apply the same sort of locking done in
> >      sys/dev/acpica/acpi.c rev 1.196 a while ago:
> >   
> >   Grab Giant around calls to DEVICE_SUSPEND/RESUME in
> >   acpi_SetSleepState().
> >   If we are resuming non-MPSAFE drivers, they need Giant held for them.
> >   This may fix some obscure suspend/resume problems.  It has fixed keyrate
> >   setting problems that were triggered by cardbus (MPSAFE) changing the
> >   ordering for syscons resume (non-MPSAFE).  Also, add some asserts that
> >   Giant is held in our suspend/resume and shutdown methods.
> >   
> >   Submitted by: Marko Zec
> >   
> >   Revision  Changes    Path
> >   1.149     +10 -0     src/sys/i386/bios/apm.c
> 
> Why are we adding new unconditional giant acquisitions to the tree? 
> Devices indicate whether or not they are mpsafe, why can't this be made 
> conditional?

Because newbus isn't yet mp safe.

Warner