From owner-freebsd-ports@FreeBSD.ORG Tue Jan 24 20:10:35 2006 Return-Path: X-Original-To: ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6387A16A420; Tue, 24 Jan 2006 20:10:35 +0000 (GMT) (envelope-from pauls@utdallas.edu) Received: from smtp1.utdallas.edu (smtp1.utdallas.edu [129.110.10.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1986343D45; Tue, 24 Jan 2006 20:10:35 +0000 (GMT) (envelope-from pauls@utdallas.edu) Received: from utd59514.utdallas.edu (utd59514.utdallas.edu [129.110.3.28]) by smtp1.utdallas.edu (Postfix) with ESMTP id B864E388CD2; Tue, 24 Jan 2006 14:10:34 -0600 (CST) Date: Tue, 24 Jan 2006 14:10:34 -0600 From: Paul Schmehl To: Joe Marcus Clarke Message-ID: <9B2BA4ED22481885FB14746D@utd59514.utdallas.edu> In-Reply-To: <43D661F0.5090802@FreeBSD.org> References: <6E2E84047A522AA3CF4F3F8D@utd59514.utdallas.edu> <43D65689.8050207@vonostingroup.com> <0CAD779515C871FE2C1AC21E@utd59514.utdallas.edu> <43D661F0.5090802@FreeBSD.org> X-Mailer: Mulberry/3.1.6 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: ports@FreeBSD.org, Frank Laszlo Subject: Re: Something wrong with portlint? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2006 20:10:35 -0000 --On Tuesday, January 24, 2006 12:20:48 -0500 Joe Marcus Clarke wrote: >>>> >>> There has been some extensive port framework changes (see -ports >>> archive) If you send the PR in question, I'd gladly take a look at it >>> for you. Thanks >>> >> There's actually two - 92239 and 92241 > > In 92239, you moved the CATEGORIES line to the wrong location. If you > put CATEGORIES right PORTVERSION, it passes portlint just fine. With > 92241, you have a blank line between PORTVERSION and CATEGORIES. You > can't do that. > I moved them because portlint complained about where they were. That was the entire point of my question. Did you actually run portlint against the PRs? Or are you just assuming from looking at them? I know where CATEGORIES is *supposed* to go (according to the Porter's Handbook), but portlint didn't like it there. It kept complaining when it put it where I normally do, which is right after PORTVERSION and right before DISTVERSION, etc. If I do this: PORTNAME= barnyard PORTVERSION= 0.2.0 CATEGORIES= security MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= barnyard MAINTAINER= pauls@utdallas.edu COMMENT= An output system for Snort I get this: portlint -A WARN: /usr/ports/security/barnyard.new/pkg-plist: Both ``%%PORTDOCS%%@dirrm %%DOCSDIR%%'' and ``%%PORTDOCS%%@unexec %D/%%DOCSDIR%% 2>/dev/null || true'' are missing. At least one should be used. FATAL: Makefile: non-comment line in comment section. WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make CVS happy. FATAL: Makefile: extra item "MAINTAINER" placed in the PORTNAME section. FATAL: Makefile: extra item "COMMENT" placed in the PORTNAME section. FATAL: Makefile: PORTNAME has to be there. FATAL: Makefile: PORTVERSION or DISTVERSION has to be there. FATAL: Makefile: CATEGORIES has to be there. FATAL: Makefile: extra item "RUN_DEPENDS" placed in the MAINTAINER section. FATAL: Makefile: COMMENT has to be there. 10 fatal errors and 2 warnings found. If I do this: PORTNAME= barnyard PORTVERSION= 0.2.0 MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= barnyard CATEGORIES= security MAINTAINER= pauls@utdallas.edu COMMENT= An output system for Snort I get this: portlint -A WARN: /usr/ports/security/barnyard.new/pkg-plist: Both ``%%PORTDOCS%%@dirrm %%DOCSDIR%%'' and ``%%PORTDOCS%%@unexec %D/%%DOCSDIR%% 2>/dev/null || true'' are missing. At least one should be used. FATAL: Makefile: non-comment line in comment section. WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make CVS happy. FATAL: Makefile: PORTNAME has to be there. FATAL: Makefile: PORTVERSION or DISTVERSION has to be there. 5 fatal errors and 2 warnings found. Maybe my portlint is screwed up? Paul Schmehl (pauls@utdallas.edu) Adjunct Information Security Officer University of Texas at Dallas AVIEN Founding Member http://www.utdallas.edu/ir/security/