From owner-freebsd-hackers Wed Jan 28 13:12:30 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA23649 for hackers-outgoing; Wed, 28 Jan 1998 13:12:30 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from ifi.uio.no (0@ifi.uio.no [129.240.64.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA23194; Wed, 28 Jan 1998 13:10:36 -0800 (PST) (envelope-from dag-erli@ifi.uio.no) Received: from hrotti.ifi.uio.no (2602@hrotti.ifi.uio.no [129.240.64.15]) by ifi.uio.no (8.8.8/8.8.7/ifi0.2) with ESMTP id WAA18031; Wed, 28 Jan 1998 22:10:27 +0100 (MET) Received: (from dag-erli@localhost) by hrotti.ifi.uio.no ; Wed, 28 Jan 1998 22:10:27 +0100 (MET) To: Kazutaka YOKOTA Cc: hackers@FreeBSD.ORG, msmith@FreeBSD.ORG Subject: Re: Graphical screen saver References: <199801280640.PAA25860@zodiac.mech.utsunomiya-u.ac.jp> Organization: Gutteklubben Terrasse X-url: http://www.ifi.uio.no/~dag-erli/ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit From: dag-erli@ifi.uio.no (Dag-Erling Coidan Smørgrav) Date: 28 Jan 1998 22:10:26 +0100 In-Reply-To: Kazutaka YOKOTA's message of "Wed, 28 Jan 1998 15:40:35 +0900" Message-ID: Lines: 12 X-Mailer: Gnus v5.5/Emacs 19.34 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk Kazutaka YOKOTA writes: > In your code, video mode switching is protected by a splhigh()/splx() > pair. I think splhigh() is overkill. We had better use spltty() > instead. As I said earlier, I ripped the mode switching code from splashkit. I suspected the splhigh() was overkill, but preferred to remain conservative. -- * Finrod (INTJ) * Unix weenie * dag-erli@ifi.uio.no * cellular +47-92835919 * RFC1123: "Be liberal in what you accept, and conservative in what you send"