From owner-cvs-all@FreeBSD.ORG Mon Apr 9 16:32:10 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AFDDD16A40D; Mon, 9 Apr 2007 16:32:10 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at [128.131.111.2]) by mx1.freebsd.org (Postfix) with ESMTP id 6904E13C487; Mon, 9 Apr 2007 16:32:10 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from acrux.dbai.tuwien.ac.at (acrux [128.131.111.60]) by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP id 7C95113789; Mon, 9 Apr 2007 18:32:09 +0200 (CEST) Received: by acrux.dbai.tuwien.ac.at (Postfix, from userid 1203) id DB1041A7C9; Mon, 9 Apr 2007 18:32:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by acrux.dbai.tuwien.ac.at (Postfix) with ESMTP id C9E421A7C7; Mon, 9 Apr 2007 18:32:13 +0200 (CEST) Date: Mon, 9 Apr 2007 18:32:13 +0200 (CEST) From: Gerald Pfeifer To: Colin Percival In-Reply-To: <461A172F.4000202@freebsd.org> Message-ID: References: <200703311441.l2VEfSgZ070944@repoman.freebsd.org> <20070331192739.GA69788@xor.obsecurity.org> <461A172F.4000202@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, Gerald Pfeifer , cvs-all@FreeBSD.org, Kris Kennaway Subject: Re: cvs commit: ports/lang/gcc43 pkg-descr X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2007 16:32:10 -0000 On Mon, 9 Apr 2007, Colin Percival wrote: > Could I suggest > s|increase the the datasize limit|set kern.maxdsiz in /boot/loader.conf| > for the benefit of people who aren't familiar with loader.conf? Good input. How about the following update to my original patch? (Note that the user still may need to increase the datasize limit beyond the setting in /boot/loader.conf, for example in /etc/login.conf or one or the other login script.) Gerald Index: Makefile =================================================================== RCS file: /home/pcvs/ports/lang/gcc43/Makefile,v retrieving revision 1.304 diff -u -3 -p -r1.304 Makefile --- Makefile 9 Apr 2007 13:23:10 -0000 1.304 +++ Makefile 9 Apr 2007 15:32:11 -0000 @@ -135,6 +135,15 @@ PLIST_SUB+= JAVA="@comment " pre-everything:: @${ECHO_MSG} "Making GCC ${DISTNAME:S/^gcc-//} for ${OPSYS} ${OSREL} target=${CONFIGURE_TARGET}" +.if ! defined(WITHOUT_JAVA) + @DSIZ=700000; DSIZBYTE=734003200; \ + if [ `ulimit -d` -lt $$DSIZ ]; then \ + echo "You need to increase the datasize limit to at least $$DSIZ \ + (and set kern.maxdsiz=\"$$DSIZBYTE\" in /boot/loader.conf) to \ + build with Java support." | ${FMT} -s; \ + exit 1; \ + fi +.endif post-patch: @${REINPLACE_CMD} -e 's|\(const char version_string.*\)";|\1 [FreeBSD]";|' \