Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Sep 2017 19:32:12 -0700
From:      Ryan Libby <rlibby@freebsd.org>
To:        Ngie Cooper <ngie@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   Re: svn commit: r323299 - stable/11/lib/msun/tests
Message-ID:  <CAHgpiFwBSkY_aXn1oMn9aoF62Xs8OEKjAEJo8-2aLe_eu152Ww@mail.gmail.com>
In-Reply-To: <CAHgpiFzb0AfDZ0czB9m53X9Z77UnwHSEA5iyRt3kTuTU7xHhwQ@mail.gmail.com>
References:  <201709080437.v884bnIh029199@repo.freebsd.org> <CAHgpiFzb0AfDZ0czB9m53X9Z77UnwHSEA5iyRt3kTuTU7xHhwQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 12, 2017 at 2:45 AM, Ryan Libby <rlibby@freebsd.org> wrote:
> On Thu, Sep 7, 2017 at 9:37 PM, Ngie Cooper <ngie@freebsd.org> wrote:
>> Author: ngie
>> Date: Fri Sep  8 04:37:49 2017
>> New Revision: 323299
>> URL: https://svnweb.freebsd.org/changeset/base/323299
>>
>> Log:
>>   MFC r321455:
>>
>>   Raise WARNS to 1
>>
>>   This will enable warnings with the msun tests.
>>
>> Modified:
>>   stable/11/lib/msun/tests/Makefile
>> Directory Properties:
>>   stable/11/   (props changed)
>>
>> Modified: stable/11/lib/msun/tests/Makefile
>> ==============================================================================
>> --- stable/11/lib/msun/tests/Makefile   Fri Sep  8 04:35:44 2017        (r323298)
>> +++ stable/11/lib/msun/tests/Makefile   Fri Sep  8 04:37:49 2017        (r323299)
>> @@ -4,8 +4,6 @@
>>
>>  TESTSRC=       ${SRCTOP}/contrib/netbsd-tests/lib/libm
>>
>> -WARNS?=                0
>> -
>>  # All architectures on FreeBSD have fenv.h
>>  CFLAGS+=       -DHAVE_FENV_H
>>
>> @@ -85,6 +83,8 @@ IGNORE_PRAGMA=
>>  SRCS.ilogb2_test=      ilogb_test.c
>>
>>  LIBADD+=       m
>> +
>> +WARNS?=                1
>>
>>  # Copied from lib/msun/Makefile
>>  .if ${MACHINE_CPUARCH} == "i386"
>
> This seems to have broken the i386 build [1].  Did you mean to MFC it
> with r321483?
>
> [1] https://ci.freebsd.org/job/FreeBSD-stable-11-i386-build/1521/

I MFC'd head r321483 to stable/11 in r323515 in order to unbreak the
build for i386.  I realize this may not have been the plan, so, Ngie,
you may like to follow up on that further.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHgpiFwBSkY_aXn1oMn9aoF62Xs8OEKjAEJo8-2aLe_eu152Ww>